Giter Club home page Giter Club logo

Comments (2)

omarryhan avatar omarryhan commented on June 14, 2024 1

Nice catch. I should've opted for quote instead of quote_plus. As highlighted by the urllib docs:

By default, this function is intended for quoting the path section of a URL.

Also, according to the urllib docs, the only two differences between quote_plus and quote is that:

  1. quote_plus replaces spaces with a + instead of a %20.
  2. It does not treat forwards slashes as safe chars.

So, I suspect that changing to quote might cause future data inconsistency for some of the users of this lib. E.g. a user created a reaource using an encoded forward slash, but now can't fetch it because forward slashes are being escaped. That's assuming that Google APIs accept URL data in non idempotent requests, which i'd say is unlikely.

Anyway, I think it's best to change it to the correct quote function and bump the version up by one major version to give people a heads up about the change. What do you think?

Thanks for raising the issue!

from aiogoogle.

leandrotoledo avatar leandrotoledo commented on June 14, 2024 1

Sounds good to me! 👍
Thanks.

from aiogoogle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.