Giter Club home page Giter Club logo

Comments (9)

omarryhan avatar omarryhan commented on June 7, 2024

Hey Matresh, are you installing directly from the git repo or from Pypi (via pip)?

Because in the manifest.in file, I am excluding the tests folder. And on my machine, the tests directory is in fact not being included.

I think it would be better if we exclude in one place i.e. manifest.in. As per this, wouldn't adding recursive-exclude tests* to the manifest.in be a better solution?

from aiogoogle.

ajax-kovalchuk-d avatar ajax-kovalchuk-d commented on June 7, 2024

Yeah, Using Pypi:
pip install aiogoogle

Using manifest.in will be better i think.

from aiogoogle.

ajax-kovalchuk-d avatar ajax-kovalchuk-d commented on June 7, 2024

I never worked with manifest.in but if I'm correctly understand prune must be similar to recursive-exclude tests* but prune currently not working

from aiogoogle.

omarryhan avatar omarryhan commented on June 7, 2024

Hmm, weird. Can you try and see if recursive-exclude tests* works for you instead of prune tests. If it does, I can merge that.

from aiogoogle.

ajax-kovalchuk-d avatar ajax-kovalchuk-d commented on June 7, 2024

Im not sure how can i test it, directly pip install from git repo is representative?
Or need to upload into PyPi ?

from aiogoogle.

ajax-kovalchuk-d avatar ajax-kovalchuk-d commented on June 7, 2024

I have 2 packages aiogoogle and test in top_level.txt

And 2 packages in -site-packages

image
image

from aiogoogle.

omarryhan avatar omarryhan commented on June 7, 2024

This is weird.

Im not sure how can i test it, directly pip install from git repo is representative?

Yes. Clone it, then make your changes. Then, in the CLI, write: python setup.py sdist. Then , you'll find the new package in the dist directory.

I did just that right now, and added the line that you wanted to add to the setup.py file and it didn't change anything. I also tried replacing prune with global-exclude and replacing tests/ with **/*tests and also nothing.

All of the methods I tried didn't include the tests directory in the .tar package. Also, all of them included the line tests in the top_level.txt file.

Are you installing directly from Github? Maybe that's why you're getting this error.

If adding exclude=["tests"] is the only thing that works for you, I don't mind merging it.

from aiogoogle.

ajax-kovalchuk-d avatar ajax-kovalchuk-d commented on June 7, 2024

Thanks for help, I've tested it for myself and any type of exclude from MANIFEST.in isn't working for me. exclude=["tests"] is not working too, but exclude=['tests*'] is working fine, i will create pull request with that changes soon

from aiogoogle.

omarryhan avatar omarryhan commented on June 7, 2024

Alrighty. Thank you Matresh! I'll release a new version now.

from aiogoogle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.