Giter Club home page Giter Club logo

Comments (11)

omahili avatar omahili commented on May 28, 2024 3

Ok, thank you for going deep into it. I'll investigate this!

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024 1

Hi @omahili

thanks for your answer. I will build you an example today.

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024 1

Hi @omahili,

sorry for the delay, was caught up in work. I created the repro.
https://github.com/hirbod/autoscroll-issue-react-native-reorderable-list

I also created an Expo Snack (with the same requirements as in your README, but this is not even working at all)
https://snack.expo.dev/@hirbod/autoscroll-issue

The git reproduction is working as expected but with said auto scroll issue
(barely scrolling, sometimes not scrolling/not recognizing when to start scrolling, like in the video).

I've added a README for you inside the repo.

Reproduction

  1. Clone repository https://github.com/hirbod/autoscroll-issue-react-native-reorderable-list.git
  2. Run yarn to install everything
  3. Install expo-cli globally (npm install -g expo-cli)
  4. Run expo start in your Root and scan the QR
    or search in your network with the Expo Go App (available in Apple and Play Store)

If you prefer to run a bare react-native project, just hit expo eject and it will create iOS and Android folders which you can use with react-native CLI OOTB.

I just added explanation here since I am not aware if you have used Expo before.

  • Tested with REA 2.2.0, 2.3.1, 2.5.0 and 2.7.0.
  • Tested with RNGH 1.3.0, 2.2.0, 2.3*

The result was always the same. Autoscrolling not working correctly, even without a ListHeaderComponent

FYI: I also tried a JS-navigation stack (instead of the native-stack), but that didn't make any difference.

P.S: It's about iOS, I haven't tested Android yet.

from react-native-reorderable-list.

omahili avatar omahili commented on May 28, 2024 1

I'm working on the next version which will include a fix for this. I should release it this week.

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024 1

This are good news!! Going to give it a try today, thanks for your efforts so far :).

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024

@omahili I made you a quick video showing the issue. This example is even without a bottom tab.
I think that the area for autoscrolling is not calculated correctly. I also tried changing the provided props tresholds but no success unfortunately.

RPReplay_Final1649521190.mp4

from react-native-reorderable-list.

omahili avatar omahili commented on May 28, 2024

Hi @hirbod, thank you for the appreciation!

Could you provide a minimum reproducible example of this bug, so I can test it?

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024

@omahili i just tested Android and its working great. So this issue is indeed an iOS only problem

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024

Hi mate, any update on this? :)

from react-native-reorderable-list.

omahili avatar omahili commented on May 28, 2024

Fixed in #7 and released with version 0.4.0

from react-native-reorderable-list.

hirbod avatar hirbod commented on May 28, 2024

@omahili thanks a ton for this. Working GREAT! Nice.

from react-native-reorderable-list.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.