Subtle bug in jquery-function about react-native-signalr HOT 4 OPEN

Nice find! And very good reporting. I do undertand the issue.

Do you have any code that fixes the problem? Anything you can post here?
Otherwise you could maybe post a reproduce senario or something?

Olof

from react-native-signalr.

The way I solved it was to move the line const events = subject.events || {}; to the inside of every emulated jquery function (unbind, bind, triggerhandler) like this:

`unbind(event, handler) {
const events = subject.events || {};
let handlers = events[event] || [];

  if (handler) {
    const idx = handlers.indexOf(handler);
    if (idx !== -1) {
      handlers.splice(idx, 1);
    }
  } else {
    handlers = [];
  }

  events[event] = handlers;
  subject.events = events;
},
bind(event, handler) {
  const events = subject.events || {};
  const current = events[event] || [];
  events[event] = current.concat(handler)
  subject.events = events;
},
triggerHandler(event, args) {
  const events = subject.events || {};
  const handlers = events[event] || [];
  handlers.forEach(fn => {
    if (args === undefined) {
      args = { type: event };
    }
    if (!Array.isArray(args)) {
      args = [args];
    }
    if (args && args[0] && args[0].type === undefined) {
      args = [{
        type: event
      }].concat(args || []);
    } else {
      args = args || [];
    }

    fn.apply(this, args);
  });
}`

After these changes, everything worked just fine.

from react-native-signalr.

Ah! Great, than I understood you correctly.
I did a change here last night before pushing the new version.
I did not do any difference for basic functionality, so I included what I thought might work.
Can you take a look here:

https://github.com/olofd/react-native-signalr/blob/master/src/jquery-function.js#L16

And test out the new version on npm that the problem is solved?

from react-native-signalr.

Hi again :)

Unfortunately with the new version I have another error when connecting to SignalR: "method GET must not have a request body"

I traced it to this line in ajax.js

request.send(options.data && qs(options.data));

It seems options.data is an empty object and it's always true, so it will try to send an empty body, even when there is no body to be sent.

If I set options.data = null before this call, it works correctly.

Can you check this out? Thanks for the work!

from react-native-signalr.