Add gamepad/controller support for couch reading about opencomic HOT 9 CLOSED

Hi.

I have added preliminary support for gamepads 759ee60

These are the functions that the buttons currently do, if you can think of any better layouts or other functions for the buttons that are not currently being used, please let me know:

• A: Open
• B: Go back
• LSB/RSB/D-PAD: Browse in library and Next/Prev page in reading
• LB/RB: Next/Prev page
• LT/RT: Zoom out/in
• Start: Reset zoom
• Back: Add/Remove bookmark

Currently, there are some things that still don't work correctly.

• When browsing the library if you go down using the gamepad the scroll still does not follow it.
• Going back focuses on the first element instead of the one just exited.

If you can try it and tell me if there are any other errors that you have not seen, it would be very helpful https://github.com/ollm/OpenComic#installation-and-starting-for-development

from opencomic.

I reopen this until all the Gamepad functions are implemented, although I don't know if it will be possible to implement the possibility of adding folders without implementing a proper navigation system to select them.

from opencomic.

I publish a new version with improved gamepad navigation d1290f5 and gamepad shortcuts 0a4a459

v1.0.0-beta.2

This includes the following improvements:

• Gamepad menu to close OpenComic and access to header bar menus.
• Control magnifying glass using right stick when is active.
• Navigate to the settings, language and theme pages.
• Personalize buttons actions in settings.

from opencomic.

Following the development installation guide and starting OpenComic, I paired a PS4 gamepad via bluetooth and it works great, specially using the webtoon view, it also respects analog acceleration properly and it feels great browsing through the pages with a controller, far from the big screen.

Having the ability to browse Configurations using the gamepad can be useful, specially if the user wants to add or remove folders, or opening single files.

Since X/Y are free, maybe Y could be used to bring the File menu and X add bookmarks?
Most people have either the Xbox or PS controllers and the standard from other manufactures follow the same basic layouts and buttons, what about L3/R3 to reset zoom/toggle full screen?

Can OpenComic to be set to always start in full screen, by the way?

Dpad and left analog, along with L/R browse pages, I haven't used the Floating magnifying glass yet, but would it be possible to make it usable with the right analog?

OpenComic is probably the only CBZ/PDF reader with native gamepad support, with the upcoming improvements for reading PDF and populating thumbnails, I'll show this for thousands and they'll use it even for reading game manuals, magazines and more.

Apart from the controller, some CBZ/CBR/PDF files are returning errors when trying to open them, related to decompression or something, they work fine with another CBZ reader.

[Window Title]
Error when unzipping

[Main Instruction]
An error occurred while trying to unzip the file.

[Content]
invalid signature: 0x21726152

from opencomic.

Following the development installation guide and starting OpenComic, I paired a PS4 gamepad via bluetooth and it works great, specially using the webtoon view, it also respects analog acceleration properly and it feels great browsing through the pages with a controller, far from the big screen.

Having the ability to browse Configurations using the gamepad can be useful, specially if the user wants to add or remove folders, or opening single files.

Since X/Y are free, maybe Y could be used to bring the File menu and X add bookmarks? Most people have either the Xbox or PS controllers and the standard from other manufactures follow the same basic layouts and buttons, what about L3/R3 to reset zoom/toggle full screen?

Thanks for the button configuration suggestions, for now I have already implemented the ones for the R3/L3 buttons f42d37d and d3c5698

What do you mean by "used to bring the File menu"? Show/hide left side menu?

Can OpenComic to be set to always start in full screen, by the way?

I have added a preference in the settings to do this 68eff46

Dpad and left analog, along with L/R browse pages, I haven't used the Floating magnifying glass yet, but would it be possible to make it usable with the right analog?

Yes, I can try to see how it works.

Apart from the controller, some CBZ/CBR/PDF files are returning errors when trying to open them, related to decompression or something, they work fine with another CBZ reader.
[Window Title] Error when unzipping

[Main Instruction] An error occurred while trying to unzip the file.

[Content] invalid signature: 0x21726152

It seems that this file is a RAR file but with a ZIP (CBZ) extension, I have made it try to decompress the file as RAR when that signature is detected aa39a6a

from opencomic.

What do you mean by "used to bring the File menu"? Show/hide left side menu?

Mostly to add folders, open files and even exit the application using the gamepad, or it could be achieved by making the cursor (that is the same for choosing what magz/comics we want to open and browse pages) to be able to browse those tabs, but it could be a bit less ideal.

About the file issue, you're right, I extracted its content and created a zip out of the extracted pages without any compression "store" option, named it as cbz and OpenComic opened the file right away, showing its thumbnails, too.

Thanks for adding the option so OpenComic is able to start in full screen, the magnifying glass consideration and all the support and the buttons functions as well!

from opencomic.

Closed as completed in 759ee60 and available in v1.0.0-beta.1

Feel free to reopen the issue if you find any bugs.

from opencomic.

The latest 1.0.0-beta.1 build works fine with the controller and it's really nice to read it far from the big screen. It will be nice if the cursor isn't limited to just browsing the already added folders/files, making it possible to use a button dedicated to the menus and settings, like adding folders and preferences. Maybe adding a confirmation when pressing 'back' or a dedicated button to close the application, since there's no way to close OpenComic with the gamepad alone.

from opencomic.

Due in the latest beta version (v1.0.0-beta.5) all features have been implemented (Except for being able to add folders, but you can use the master folders as a replacement), I close for now the issue.

Any other function or bug related will have to open a new issue.

from opencomic.