Giter Club home page Giter Club logo

Comments (4)

oliverbooth avatar oliverbooth commented on August 27, 2024

Interesting suggestion. Will add this soon

from x10d.

oliverbooth avatar oliverbooth commented on August 27, 2024

No string allocation because of span usage.

I'd like to point out that this wouldn't apply because the FullName property already returns a string. Calling AsSpan is pretty pointless and won't save an allocation if the property already allocates before-hand.

Fortunately, the property does not allocate and in fact returns a private string that's already allocated in the class. For this reason it's safe to just call string.Equals

from x10d.

oliverbooth avatar oliverbooth commented on August 27, 2024

This also brings into question the need for such a method, when the caller could just call string.Equals(value.FullName, other.FullName). I'm removing the approved tag for now, while this is discussed.

from x10d.

oliverbooth avatar oliverbooth commented on August 27, 2024

OP has redacted this request.

from x10d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.