Comments (4)
Interesting suggestion. Will add this soon
from x10d.
No string allocation because of span usage.
I'd like to point out that this wouldn't apply because the FullName
property already returns a string. Calling AsSpan
is pretty pointless and won't save an allocation if the property already allocates before-hand.
Fortunately, the property does not allocate and in fact returns a private string that's already allocated in the class. For this reason it's safe to just call string.Equals
from x10d.
This also brings into question the need for such a method, when the caller could just call string.Equals(value.FullName, other.FullName)
. I'm removing the approved
tag for now, while this is discussed.
from x10d.
OP has redacted this request.
from x10d.
Related Issues (20)
- [Request]: IsPointOnLine HOT 1
- [Request]: Vector rounding HOT 1
- [Request]: Color.GetClosestConsoleColor HOT 1
- Automate upm branch update
- Remove TODOs and empty implementations introduced by #70
- [Request]: MinMax for built-in numeric types
- Add unit tests for methods introduced by #70 HOT 1
- Only publish nightly builds on commits to main, not develop HOT 1
- [Bug]: snupkg verification fails HOT 6
- Migrate to NUnit
- Remove soft dependency on Unity3D.SDK HOT 2
- Merge X10D.Performant in with this repository HOT 2
- Remove calls to throw helpers for validating input
- Sunset of X10D.DSharpPlus
- Sunset of X10D.Unity
- Drop support for .NET Standard 2.1
- Add .NET 8 build target HOT 2
- Drop support for .NET 7 HOT 1
- dotCover via SonarCloud is reporting 0% coverage on new code HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from x10d.