`warrior.feel()` exposes floor object about warriorjs HOT 4 CLOSED

This will probably become an issue if #69 gets fixed. Since players can then easily discover this object.

from warriorjs.

Hello @nloomans, thanks for the report. This is a known issue that was already fixed prior to the big refactor I recently made (see #26). I didn't cherry-pick those changes intentionally because I wanted to explore other ways of fixing this (maybe simpler/more elegant), e.g. Symbols for "private" properties. Let me put some additional thought on this, suggestions are also welcome.

from warriorjs.

Thanks! Symbols seem like a good solution. I did a few test and it should be noted that, while symbols are not accessible in the vm context, their content can still be printed using console.log. JSON.stringify, however, doesn't print symbols.

from warriorjs.

@nloomans I opened a PR with a fix for this, just letting you know in case you're curious.

Symbols ended up not being a good solution for this, because one could still access the "private" members by using Object.getOwnPropertySymbols.

from warriorjs.