Comments (11)
I will have look at your suggestions. In the meantime, if you want to play around a "well known bad environment":
docker run --rm -it hojerst/shell@sha256:efd73cbe8118e5c99710c3d1af87e579087ed5ef0dc2b32a8db90e10f0633479
all i see is as soon as i upgraded from v4.8.1 to v5.0.1 this behaviour appeared:
https://gitlab.com/hojerst/dotfiles/-/commits/main?ref_type=heads
Commit 399da6dfa72454f79c94c07b99a58a132f985ad2 in my dotfiles worked fine
Commit b52877539dbe22da963e3f94b279284868d42913 in my dorfiles introduced the bug/weirdness (this commit only updates zsh-abbr from v4.8.1 to v5.0.1)
you can even play around with it in the above docker container:
# first commit broken
yadm checkout b52877539dbe22da963e3f94b279284868d42913
exec zsh
# commit before the upgrade worked fine
yadm checkout 399da6dfa72454f79c94c07b99a58a132f985ad2
exec zsh
from zsh-abbr.
the first up arrow goes to the last command in history, and subsequent up arrows do history substring search based on that last command in history.
Yes, this is same as my issue.
On Ubuntu 22.04, I rollback to v4.8.2 as version >= v4.8.3 have this issue.
from zsh-abbr.
Thanks for the report!
I can't replicate the bug.
This (as you may know) is called history substring search. Nothing about zsh-abbr or zsh-autosuggestions should give you history substring searching. (I use zsh-abbr and zsh-autosuggestions, and to get history substring searching I additionally use zsh-history-substring-search.) But maybe one of them is!
To test the zsh-abbr v5 idea, you can try temporarily downgrading to 4.x. https://zsh-abbr.olets.dev/migrating-between-versions.html#downgrading-v5-to-v4
Looking briefly at your dotfiles, I think zsh-fzf-history-search is a likely suspect. I don't use fzf but my impression is substring matching is one of its selling points. Based on that impression, I'd expect an fzf history search plugin to perform substring history searches. Have you tried removing zsh-fzf-history-search?
OMZ also ships with an optional history substring search plugin. I think that plugin isn't enabled in your config, but it's worth double checking.
from zsh-abbr.
Reproduction in docker is A+++ bug reporting!
I misunderstood the report. So the first up arrow goes to the last command in history, and subsequent up arrows do history substring search based on that last command in history.
Confirmed the behavior and that the only change is the zsh-abbr upgrade, and that removing either zsh-autosuggestions or zsh-abbr resolves it.
I've pushed up a new branch for debugging this. Try switching zsh-abbr to the branch issues/91
(I'm not a yadm user and don't know how best to do that). That won't be a fix —now zsh-autosuggestions won't work as well if at all— but at least it will help us pin down the problem.
from zsh-abbr.
Hello, I think I am facing the saming issue. And now I am using v4.9.2 for resolving this issue temporarily.
[OS] ArchLinux x86_64
[Plugins] I have installed zsh-abbr and zsh-autosuggestions.
[Issue] Keep pressing up arrow in shell, cannot show all histories.
[More info] The issue exists on zsh-abbr v4.9.3 and afterwards version. v4.9.2 works fine. (ArchLinux x86_64)
from zsh-abbr.
Thanks for the report @ShangjinTang!
I think I am facing the saming issue
Does this describe your problem? (from my comment above)
the first up arrow goes to the last command in history, and subsequent up arrows do history substring search based on that last command in history.
from zsh-abbr.
Related Issues (20)
- `zsh-abbr` not working when the `viins` keymap is selected HOT 5
- abbr command completion
- [Bug report] bad math expression: operator expected at `Jan 1 03:...' HOT 4
- [feature] abbreviations may place the cursor anywhere in the expansion, instead of only at the end HOT 1
- Could you publish tarball for v4.8? HOT 2
- Cannot use scopes HOT 2
- Drop .zwc files from repo HOT 6
- Could you publish tarball for v4.8.2? HOT 1
- zsh-autosuggestions' suggestions don't clear after the line is accepted HOT 13
- [Bug report] testing issue form
- [Bug report] One more .zwc in repo remains HOT 2
- Deleted the branch `master`
- acknowledge committers
- allcontributors 1/ HOT 2
- acknowledge bug reporters HOT 1
- `!` is escaped in v5, but wasn’t in v4 HOT 12
- `abbr c` does not clear abbreviations created with the pattern `abbr x=y` HOT 3
- Teach `add` about `--force`
- Conflict warning logged in all new sessions when adding an abbreviation in zshrc HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zsh-abbr.