Comments (4)
I agree, data
should handle this. Can you provide patch?
I haven't time to fix this now.
from p5-mojo-smtp-client.
Initial idea is here: https://github.com/karel-m/p5-Mojo-SMTP-Client/commit/ea75bd07ad0650d0c3b627a4d6f29ff709832a16
After looking at https://metacpan.org/source/SHAY/libnet-3.08/lib/Net/Cmd.pm#L507 I am not sure whether we shouldn't also normalize newlines LF
>> CRLF
. Unfortunately straightforward replace like $line =~ s/\015?\012(\.?)/\015\012$1$1/sg;
caused t/03_smtp_nb.t
failure. I'll try to investigate more (basically the logic in Net::Cmd
is even more complicated).
from p5-mojo-smtp-client.
Another improvement: https://github.com/karel-m/p5-Mojo-SMTP-Client/commit/259918048b79524ab25a0d11afa848198f929783
Now the replacing regexp is handling .
escaping as well as CRLF
normalization.
It works fine when data
is the scalar with actual data (all at once), however there might be troubles when data
is coderef and the sequence \r\n,
is not in one chunk - like blexxxxx\r\n
in one chunk and .blexxx
in the next chunk.
It seems like we will inevitably end up mimicing sub datasend
from Net::Cmd
https://metacpan.org/source/SHAY/libnet-3.08/lib/Net/Cmd.pm#L459 (see $first_ch
/ $last_ch
kung-fu)
from p5-mojo-smtp-client.
Thanks
Just released version 0.11
from p5-mojo-smtp-client.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from p5-mojo-smtp-client.