DATA & lines starting with . (dot) about p5-mojo-smtp-client HOT 4 CLOSED

I agree, data should handle this. Can you provide patch?
I haven't time to fix this now.

from p5-mojo-smtp-client.

Initial idea is here: https://github.com/karel-m/p5-Mojo-SMTP-Client/commit/ea75bd07ad0650d0c3b627a4d6f29ff709832a16

After looking at https://metacpan.org/source/SHAY/libnet-3.08/lib/Net/Cmd.pm#L507 I am not sure whether we shouldn't also normalize newlines LF >> CRLF. Unfortunately straightforward replace like $line =~ s/\015?\012(\.?)/\015\012$1$1/sg; caused t/03_smtp_nb.t failure. I'll try to investigate more (basically the logic in Net::Cmd is even more complicated).

from p5-mojo-smtp-client.

Another improvement: https://github.com/karel-m/p5-Mojo-SMTP-Client/commit/259918048b79524ab25a0d11afa848198f929783

Now the replacing regexp is handling . escaping as well as CRLF normalization.

It works fine when data is the scalar with actual data (all at once), however there might be troubles when data is coderef and the sequence \r\n, is not in one chunk - like blexxxxx\r\n in one chunk and .blexxx in the next chunk.

It seems like we will inevitably end up mimicing sub datasend from Net::Cmd https://metacpan.org/source/SHAY/libnet-3.08/lib/Net/Cmd.pm#L459 (see $first_ch / $last_ch kung-fu)

from p5-mojo-smtp-client.

Thanks
Just released version 0.11

from p5-mojo-smtp-client.