setValue() TAB causes unintended actions about minkphpwebdriver HOT 6 CLOSED

Note: If the decision is for d, can I suggest that the blur be moved to a new function, i.e.

public function setValue($xpath, $value)
{
    // ...
    $element->sendKeys($value);

    $this->blurElement($element);
}

protected function blurElement(RemoteWebElement $element)
{
    $element->sendKeys(WebDriverKeys::TAB);
}

This will at least allow me extend the driver, and then to override the blurElement function to match the documented behaviour.

from minkphpwebdriver.

Hi @oleg-andreyev,

Anything I can do to progress this? I’m really keen to get moved over to php-webdriver/webdriver.

from minkphpwebdriver.

@andrewnicols haven't looked into this issue yet, I'm in the progress of stabilizing build for the main branch.

from minkphpwebdriver.

@andrewnicols I agree that sending TAB wasn't a great idea! I think it's better to go with B.

I've tried to play with "input" event instead of "change" event and few tests are failing, so let's go just with "change" event.

Would you mind creating a PR? and please create appropriate test-case to https://github.com/oleg-andreyev/driver-testsuite/tree/integration-branch

from minkphpwebdriver.

I've created a branch for this, but I'm not sure what additional tests I should write.

The tests in tests/Js/ChangeEventTest.php should already cover this. I can add a test which ensures that the focus is still on that element, but that seems inappropriate. What do you think?

from minkphpwebdriver.

I can add a test which ensures that the focus is still on that element, but that seems inappropriate. What do you think?

yes, it's the exact scenarios I was thinking

from minkphpwebdriver.