Giter Club home page Giter Club logo

Comments (13)

g-plane avatar g-plane commented on May 25, 2024 1

For me, it's confusing.

from bundlejs.

styfle avatar styfle commented on May 25, 2024 1

Yes, I was confused too. Underlines would be better 👍

from bundlejs.

g-plane avatar g-plane commented on May 25, 2024 1

That looks good. 👍

from bundlejs.

styfle avatar styfle commented on May 25, 2024 1

Looks much better, thanks!

from bundlejs.

okikio avatar okikio commented on May 25, 2024

It's a stylistic design choice. I use it as an alternative to an underline. It really only counts as an error indicator is the squiggly lines are red.

from bundlejs.

styfle avatar styfle commented on May 25, 2024

I see. Why are those underlined?

from bundlejs.

okikio avatar okikio commented on May 25, 2024
  1. It looked cool.
  2. It helps indicate that you can click on the input and output buttons. Without the squiggly lines, the input and output buttons look like just random text that don't do anything.

from bundlejs.

okikio avatar okikio commented on May 25, 2024

@g-plane Well I'm always looking for ways to improve clarity and reduce confusion, do you have any ideas as to how I could avoid it being confusing, e.g. should I remove the underline?

from bundlejs.

g-plane avatar g-plane commented on May 25, 2024

Personally, underlines are OK, but I think they shouldn't be squiggles.

from bundlejs.

okikio avatar okikio commented on May 25, 2024

@styfle Do you feel the same?

from bundlejs.

okikio avatar okikio commented on May 25, 2024

Ok, I'll change it

from bundlejs.

okikio avatar okikio commented on May 25, 2024

This should now be fixed, please tell me what you think.

from bundlejs.

okikio avatar okikio commented on May 25, 2024

@g-plane Awesome 🎉. @styfle You're the one who created this issue, am I good to close it?

from bundlejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.