Giter Club home page Giter Club logo

Comments (7)

rhys-vdw avatar rhys-vdw commented on May 18, 2024 1

I'm very close to having finished refactoring it to use GUIDs, so you can check out the diff when it's done.

from project-curator.

rhys-vdw avatar rhys-vdw commented on May 18, 2024

This also applies to assets that are moved.

from project-curator.

rhys-vdw avatar rhys-vdw commented on May 18, 2024

This is coming up a fair bit in my team, so I'm happy to schedule a fix. Are you open to a PR @ogxd?

from project-curator.

ogxd avatar ogxd commented on May 18, 2024

Hi @rhys-vdw !
It is supposed to update when an asset is moved (and renamed I guess) but I'll check the reproduction steps when I have some time :)

static AssetMoveResult OnWillMoveAsset(string sourcePath, string destinationPath)

Yes feel free to make a PR if you think you know where the issue lies!

from project-curator.

rhys-vdw avatar rhys-vdw commented on May 18, 2024

Good timing. I just started looking into it. I'll let you know how I go.

from project-curator.

rhys-vdw avatar rhys-vdw commented on May 18, 2024

It seems a fundamental issue here is that your AssetInfo class stores a list of paths instead of asset GUIDs. Is there a reason why this is the case?

If AssetInfo stored GUIDs then there would be no need to handle the move case at all, because there is no change to references resulting in a file move.

from project-curator.

ogxd avatar ogxd commented on May 18, 2024

Mhhh it has been a while since I wrote this, I don't recall the reasons for using a path instead of the Guid. I'll have a look at it! There are probably many improvements that could be done.

from project-curator.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.