Add Type : Enable single line block char drawing (├, ─, │, └) about boxchareditor HOT 10 CLOSED

It will be refactored to using 3x3 matrix for transformations. May be it will solve issue 3 in one shot.

from boxchareditor.

It will have some DSL for support extensions drawings in future (double line, thick line).

from boxchareditor.

If it will not be have things above it will have overkill cyclomatic complexity and hard to support.

from boxchareditor.

I am not sure what you have in mind, but please go ahead and try (and refactor the simple type as well)
Feel free to take on Issues #3 ($40) and Issue #4 ($120) as well in one shot.
Can you give me an estimate on how long it will take you ?

from boxchareditor.

I try it already. There is an intermediate result. See https://github.com/GulinSS/boxchareditor/commits

from boxchareditor.

But no tests yet.

from boxchareditor.

Ok, I checkout your code. I see what you are doing - but it is still far from complete. Very few of the transformation work as expected. Here is some feedback:

• Your editor rewrote the complete html (using 4-space tabs) (thats fine with me) but make sure that this stays consistent at either 4 or 2.
• The page is a bit diff (bigger block cursor), everything moved a bit further down. Do you mind finding what caused that change and reverse it? (Given that the whole code appears different due to the tab size change I cannot tell what exactly caused it.)
• As I draw the page expands in size. As if the block fonts have different height than the spaces (&nbsp) . Can you find what is causing it and fix it.
• Make sure that you also run make lint. I see lots of lint errors.
• Finally when you make comments in githib dont't use it like a chat or IRC. (ie single line per enter). Group together your lines in a single comment. If you want to say more on a comment you have made already, edit that comment and add more lines. (# of comments in a issue is used as an indication of activity)

My skype id is tsatalos. It may be easier to connect with me directly there if you think that some of the above comments are not clear.

from boxchareditor.

Thanks for feedback! All your instructions will be applied.

Some updates: https://github.com/GulinSS/boxchareditor/commits/gh-pages
Improved link engine.

Draft works, play :-)

from boxchareditor.

I just played with it. More of the transformations work now.
Keep in mind that that when I erase I look at the neighboring cells and I recalculate them, it leaves no hanging "tails" over the erased path. Still some key things don't work, like drawing a rectangle...

You should probably revert index.html to the original - no need to be messing with the HTML in this issue..
The only files that should need to be updated is blocklines.js and a tiny amount of drawingenging.js (unless if you want to refactor simplelines.js to make it consistent with the matrix transformation method.

Can you connect with me on skype to iterate a bit faster? My skype id is tsatalos.

from boxchareditor.

You should probably revert index.html

Html page should contains Content-Type, I added this. Probably now HTML-page looks like it was.

Still some key things don't work, like drawing a rectangle.

It works but tricky: you should delete a corner and press left/right on blank corner to get nice close.

from boxchareditor.