Comments (6)
This seems to have been missed in #52 . The path also needs to be considered here
docker-volume-backup/cmd/backup/script.go
Line 537 in 9c23767
If you want to open a PR I am happy to merge it, otherwise I should be able to fix this myself later today. Thanks for the detailed description.
from docker-volume-backup.
As I'm not a Go developer I'm feeling uncomfortable tinkering in this codebase. I would appreciate if you could fix this :)
from docker-volume-backup.
Thanks a lot. I tried v2.15.2 and it is working correctly now 👍
time="2022-04-15T09:23:16Z" level=info msg="None of 7 existing remote backup(s) were pruned."
from docker-volume-backup.
A fix for this is now released in v2.15.1
, let me know if this resolves your issue.
from docker-volume-backup.
Thanks a lot for the fix.
Something is different now:
time="2022-04-14T21:14:10Z" level=warning msg="The current configuration would delete all 1 existing remote backup(s)."
time="2022-04-14T21:14:10Z" level=warning msg="Refusing to do so, please check your configuration."
It isn't looking at the root directory anymore (there are two "directories" as mentioned by the script with v2.15.0).
But this doesn't seem to be correct either: the path contains 5 files already and none of these are older than 7 days.
from docker-volume-backup.
It seems that when having path delimiters in your object keys, you also need to pass them to the S3 ListObjects call. Minio Client does this when you pass the Recursively
option. I added this in #92 and will release it as v2.15.2
The one thing I do not understand yet though is: my personal Minio Server will always list objects recursively, no matter if I pass the flag or not. Maybe this is some accidental misconfiguration or a very old version but I'm not really sure. In any case AWS S3 as well as Backblaze B2 behave the way you describe and this is also what is described in the S3 spec, so it's probably safe to fix it like this.
from docker-volume-backup.
Related Issues (20)
- Hard to understand error message during exec HOT 3
- archive-pre is triggered on each container backup instead of just container with exec-label HOT 3
- Health Check HOT 6
- Notifications Delay HOT 1
- Replace Log line feeds with HTML <br> tag HOT 3
- Backup the entire content without directory HOT 4
- Backup to subfolders HOT 2
- Resolve date in AWS_S3_PATH HOT 1
- Can't get stop during backup working HOT 2
- Remove local backup after upload to S3 HOT 3
- Invalid memory address crash when running a backup HOT 16
- Fail to configure cron schedule HOT 3
- Docker swarm error HOT 5
- "swarm exec" support HOT 1
- "input/output error" when copying file to NFS mount HOT 4
- Azure storage: Support access tier HOT 2
- schedule the docker-volume-backup? HOT 1
- [Feature] Automated backups of all named volumes HOT 6
- [FR] upgrade `shoutrrr` to v0.8.0 to support custom fields in calls to Generic Webhooks HOT 3
- [Feature] Allow BACKUP_COMPRESSION to be disabled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-volume-backup.