Prune backups doesn't seem to acknowledge AWS_S3_PATH about docker-volume-backup HOT 6 CLOSED

This seems to have been missed in #52 . The path also needs to be considered here

If you want to open a PR I am happy to merge it, otherwise I should be able to fix this myself later today. Thanks for the detailed description.

from docker-volume-backup.

As I'm not a Go developer I'm feeling uncomfortable tinkering in this codebase. I would appreciate if you could fix this :)

from docker-volume-backup.

Thanks a lot. I tried v2.15.2 and it is working correctly now 👍

time="2022-04-15T09:23:16Z" level=info msg="None of 7 existing remote backup(s) were pruned."

from docker-volume-backup.

A fix for this is now released in v2.15.1, let me know if this resolves your issue.

from docker-volume-backup.

Thanks a lot for the fix.
Something is different now:

time="2022-04-14T21:14:10Z" level=warning msg="The current configuration would delete all 1 existing remote backup(s)."
time="2022-04-14T21:14:10Z" level=warning msg="Refusing to do so, please check your configuration."

It isn't looking at the root directory anymore (there are two "directories" as mentioned by the script with v2.15.0).
But this doesn't seem to be correct either: the path contains 5 files already and none of these are older than 7 days.

from docker-volume-backup.

It seems that when having path delimiters in your object keys, you also need to pass them to the S3 ListObjects call. Minio Client does this when you pass the Recursively option. I added this in #92 and will release it as v2.15.2

The one thing I do not understand yet though is: my personal Minio Server will always list objects recursively, no matter if I pass the flag or not. Maybe this is some accidental misconfiguration or a very old version but I'm not really sure. In any case AWS S3 as well as Backblaze B2 behave the way you describe and this is also what is described in the S3 spec, so it's probably safe to fix it like this.

from docker-volume-backup.