Giter Club home page Giter Club logo

Comments (6)

kzshantonu avatar kzshantonu commented on August 23, 2024 1

Anytime. Will submit a PR in sometime

from docker-volume-backup.

m90 avatar m90 commented on August 23, 2024

About your suggestion: I'm not entirely sure why you would need / want to remove the volume? From what I understand you should be able to keep the existing volume and replace its contents with the untared archive?

from docker-volume-backup.

kzshantonu avatar kzshantonu commented on August 23, 2024

The example extracts an archive directly into a volume and overwriting data, which can cause problems if for example it's a database volume. Instead of resulting in a database that you know works (eg: last night's backup), you end up with good files mixed with stale and possibly corrupted files (if someone's restoring to recover from corruption)

from docker-volume-backup.

m90 avatar m90 commented on August 23, 2024

Hmm, I see what you mean. Then again there is probably no one size fits all approach and I have to admit I would be afraid to advise people to remove the volume by default (looking at the config examples posted in the issues here there are lots of different approaches taken, people for example add compose files and such to the backup).

Maybe it'd be a good idea to structure the docs with some possible restoration scenarios and explain the pros and cons of each in detail. What do you think?

from docker-volume-backup.

kzshantonu avatar kzshantonu commented on August 23, 2024

Agreed. I guess the doc could suggest to trigger a manual backup first, then restoring a snapshot. The word is key. Or have two scenarios of snapshots and overwriting

from docker-volume-backup.

m90 avatar m90 commented on August 23, 2024

Sounds good. I'll try to add this when time allows (unless you would like to join here, which would also be much appreciated). Thanks for your input!

from docker-volume-backup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.