Giter Club home page Giter Club logo

Comments (4)

m90 avatar m90 commented on July 21, 2024 2

You can now do this after updating to v2.9.0 and setting AWS_S3_PATH. Refer to the updated README for further info.

from docker-volume-backup.

abCobby avatar abCobby commented on July 21, 2024 1

Thanks for the quick feedback. However, I will unfortunately not manage to implement it either. We will use the image anyway.

from docker-volume-backup.

m90 avatar m90 commented on July 21, 2024

I thought this was supported by prefixing your BACKUP_FILENAME with a directory name but it seems this gets eaten here:

_, name := path.Split(s.file)

Not sure if this is to be considered a bug or intended behavior right now though as users might have started to rely on that behavior.

Maybe the easiest thing to do would be to model this like it's done with WebDAV backends, where you supply WEBDAV_PATH which then gets prefixed before uploading. So you'd provide AWS_S3_PATH and this is used for all uploads if given. Alternatively one could also provide a path in the bucket name like my-bucket/path/to/location which then gets parsed.

I personally don't need this and won't have the time to implement it soon, but in case someone wants to pick it up I'm happy to review and merge PRs, it should be a simple thing to get done.

from docker-volume-backup.

abCobby avatar abCobby commented on July 21, 2024

Thank you very much. Now the image is even more awesome.

from docker-volume-backup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.