Improve GUID matching about input HOT 6 CLOSED

Marking as bug as technically we're doing things wrong atm and "bug" will scare me into fixing it sooner

from input.

Implemented exact GUID matching as the primary database check today. Safer VID+PID extraction will come a little later.

Currently (iirc) you've got a platform-agnostic fallback if no same-platform match is made in the external or inbuilt db. The only (relatively) safe mapping fallback between platforms is between Windows and Linux.

Shall I just remove that? I have no love for this feature.

from input.

Couldn't see others at this time

Improved GUID matching will be available in v3.2.3

from input.

Sounds good

from input.

Removed the OS-agnostic fallback, which also allows us to cut the memory usage substantially!

In other news, it seems like the SDL2 database has some issues where a few of the GUIDs in the database don't match the pattern proposed. I wonder if there's been some human error in inserting these GUIDs.

For example 30000004c050000e60c0000000100000 is a "Sony DualSense" controller on MacOS, and it looks like a zero has teleported from the start of the GUID to the end. 03000000c82d00015900000000000000 and 03000000c82d00065280000000000000 also look like their PID has been offset in the middle of the string. There are a few others as well.

from input.

Fixed 😝

Feel free to point out any others

from input.