Potential Null Pointer Dereference about libdnet HOT 5 CLOSED

@qingkaishi Any suggestion on fixing this?
IMHO, this is in the test-suite and the input should be well defined, don't you think?

from libdnet.

@qingkaishi Any suggestion on fixing this?
IMHO, this is in the test-suite and the input should be well defined, don't you think?

I think you are right, it is an issue in the test suite and is not serious. But, it is easy to fix by changing the if branch to if (!p || addr_aton(p, &fr->fw_src) < 0).

from libdnet.

Thanks for getting back to me @qingkaishi !
Would you be willing to open a PR for this? Then I can easily merge it in.

from libdnet.

Thanks for getting back to me @qingkaishi !
Would you be willing to open a PR for this? Then I can easily merge it in.

Sure, see the pull request #58

from libdnet.

Merged. Closing this.
Thanks again @qingkaishi !

from libdnet.