Comments (9)
@mmulich Anything is possible :) This can be updated to just batch the 'black' source code (on disk) worse case, I just don't have time to do it at the moment. Hopefully soon though.
from brunette.
Correct me if I'm wrong, but this is a critical flaw that can't be fixed...
Any monkey patching you do at the start of brunette is lost due to processes being started in the background (all new memory space). Without some cooperation from the black code this can't be solved. Right?
from brunette.
Is this fixed by #4 or it is a separate issue?
from brunette.
No, this is a separate issue; hence the different ticket :). I didn't really have an easy way to fix this as I did not dig too deep into how black is working.
from brunette.
Maybe there's a way to disable that daemon process to avoid this.
from brunette.
@svaningelgem When I run your example above, single quotes are used to format the files. Can you provide another working example to reproduce this one?
from brunette.
I run into this problem as well. It's inconsistent though... I'm using pre-commit and occasionally need to uninstall get the commit through then re-install. It's a real PITA. But I've not been able to find any pattern to the behavior.
from brunette.
I've attached the case that is failing for me. It's a slimmed down set of changes that pre-commit (the executor of brunette) is stumbling over.
$ unzip brunette-issue-5.zip
$ cd brunette-issue-5
$ brunette . --config setup.cfg
All done! ✨ 🍰 ✨
4 files left unchanged.
from brunette.
I put together a small fix for this in #14. But as I mention there, it forces everyone into serial execution mode. Maybe that's not a huge issue... 🤷🏼
from brunette.
Related Issues (12)
- How to add exclude? HOT 2
- --single-quotes option
- black version pin is restrictive. necessary? HOT 1
- Import error HOT 1
- black>=21.5b1 is required from brunette==0.2.2 HOT 1
- pyproject.toml HOT 2
- black cythonized stuff, i think its breaking the monkeypatching HOT 1
- What actually breaks in later Black versions? HOT 1
- target-version is not configurable
- INTERNAL ERROR: `root` must be absolute but is . HOT 6
- Support both tool:brunette and brunette section in setup.ini HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brunette.