Giter Club home page Giter Club logo

Comments (9)

adler-j avatar adler-j commented on May 14, 2024

Added in above commit, is that OK?

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

The result looks correct, but what is it that makes __init__.py to be included?

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

Oh wait, now the private call() and _apply() are listed, too, see e.g. in the LinCombOperator.

from odl.

adler-j avatar adler-j commented on May 14, 2024

The result looks correct, but what is it that makes __init__.py to be included?

The lines .. automodule:: odl.operator in the odl.operator style files

Oh wait, now the private call() and _apply() are listed, too, see e.g. in the LinCombOperator.

This has been the case for quite a while, its regulated here.

Thats because users tend to put some doc in there.

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

Alright. We should then probably add a line like

Do not use this method directly. Call ``operator(x)`` to evaluate the operator.

to the _call() methods of our operators, and similarly for _apply().

from odl.

adler-j avatar adler-j commented on May 14, 2024

The best would be if the documentation of _call and _apply was somehow moved into the documentation of __call__ and the _call/_apply doc simply changed to

Do not use this method directly. Call ``operator(x)`` to evaluate the operator.

Maybe this could be done programmatically with some post processing script?

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

Interesting. I'll make a new issue so we can close this.

from odl.

adler-j avatar adler-j commented on May 14, 2024

New issue on _call and _apply is #48.

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

Yeah, forgot to link back...

from odl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.