Giter Club home page Giter Club logo

Comments (8)

adler-j avatar adler-j commented on May 14, 2024

Partial fix of this committed, we can provide a list in conf.py of methods not to skip. i added __init__ here but we may want the others as well?

from odl.

adler-j avatar adler-j commented on May 14, 2024

I also added __eq__ and __contains__, any more we want to add?

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

__init__() is definitely needed, or alternatively, we can move the code from __init__() into the class docstring. I don't think we need any one of the other functions in the doc. Many double underscores look sort of frightening.

from odl.

adler-j avatar adler-j commented on May 14, 2024

pep-258

The class constructor should be documented in the docstring for its __init__ method.

How about _lincomb and _multiply, the info in these somehow need to be exposed, no?

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

It would be great if one could just "put" the documentation of LinearSpace.lincomb() to into the child classes instead of documenting the private ones. The same for multiply(), divide() etc. Any chance to do this with Spinx?

You're right about the constructor doc, let's keep it as it is.

from odl.

adler-j avatar adler-j commented on May 14, 2024

I'll see what we can do with "reference doc"

from odl.

adler-j avatar adler-j commented on May 14, 2024

We need to remove __hash__, then we can close this.

from odl.

kohr-h avatar kohr-h commented on May 14, 2024

I see __hash__ in the config file, closing.

from odl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.