Comments (4)
zen3ger
commented on September 18, 2024
3
Why I understand the reasoning, it's quite unexpected considering you can define procs in whatever order and whatever files.
The issue is not about whether it's random or not and afaik nobody depended on specific order to make things work, quite the opposite it popped up as it didn't work and we had no clue why.
I'm guessing that delayed evaluation of when could be done similarly to how procedure bodies are delayed. It also counts as a delayed declaration when collected, it's just that all delayed whens computed at the end of processing a file and not the whole package.
from odin.
zen3ger
commented on September 18, 2024
Stack trace right before we hit the incorrect scope_lookup() call.
Note, line numbers in some places are probably off as I had some trace prints to see where and when things get added to the scopes...
#0 check_ident (c=0x7fffffffca28, o=0x7fffffffc500, n=0x7fffee6378d0, named_type=0x0, type_hint=0x0, allow_import_name=false) at src/check_expr.cpp:1743
#1 0x0000555555623a36 in check_expr_base_internal (c=0x7fffffffca28, o=0x7fffffffc500, node=0x7fffee6378d0, type_hint=0x0) at src/check_expr.cpp:10989
#2 0x000055555562302d in check_expr_base (c=0x7fffffffca28, o=0x7fffffffc500, node=0x7fffee6378d0, type_hint=0x0) at src/check_expr.cpp:11350
#3 0x000055555563198d in check_expr_or_type (c=0x7fffffffca28, o=0x7fffffffc500, e=0x7fffee6378d0, type_hint=0x0) at src/check_expr.cpp:11433
#4 0x000055555563450a in check_binary_expr (c=0x7fffffffca28, x=0x7fffffffc500, node=0x7fffee637a20, type_hint=0x0, use_lhs_as_type_hint=true) at src/check_expr.cpp:3907
#5 0x000055555562534a in check_expr_base_internal (c=0x7fffffffca28, o=0x7fffffffc500, node=0x7fffee637a20, type_hint=0x0) at src/check_expr.cpp:11184
#6 0x000055555562302d in check_expr_base (c=0x7fffffffca28, o=0x7fffffffc500, node=0x7fffee637a20, type_hint=0x0) at src/check_expr.cpp:11350
#7 0x0000555555622ef9 in check_multi_expr (c=0x7fffffffca28, o=0x7fffffffc500, e=0x7fffee637a20) at src/check_expr.cpp:11384
#8 0x0000555555622eb5 in check_expr (c=0x7fffffffca28, o=0x7fffffffc500, e=0x7fffee637a20) at src/check_expr.cpp:11427
#9 0x00005555556fdc23 in collect_when_stmt_from_file (ctx=0x7fffffffca28, ws=0x7fffee638128) at src/checker.cpp:5159
#10 0x00005555556fd0b9 in collect_file_decl (ctx=0x7fffffffca28, decl=0x7fffee6380f0) at src/checker.cpp:5264
#11 0x00005555556fcb8e in collect_file_decls (ctx=0x7fffffffca28, decls=...) at src/checker.cpp:5303
#12 0x000055555560b203 in check_import_entities (c=0x7fffee6319b0) at src/checker.cpp:5508
#13 0x0000555555599159 in check_parsed_files (c=0x7fffee6319b0) at src/checker.cpp:6498
#14 0x0000555555581e7a in main (arg_count=5, arg_ptr=0x7fffffffe138) at src/main.cpp:3333
from odin.
flysand7
commented on September 18, 2024
The compilation is deterministic, so it is not random. All of the files in the project are type checked in topological order. Within a single package, the files are sorted alphabetically, according to unicode rune ordering.
From what I received from @gingerBill on this topic a few months ago, was that this is the expected behavior, and if you're relying on the alphabetical sorting of the files, you may be doing something "weird".
In case you need it, there is a workaround. The following expression, if substituted will work.
FOO :: Foo.A when ODIN_OS == .Linux else Foo.B
The order of type checks depending on the ordering of files is expected behavior that works as intended. It's not causing bugs, because the file order in question is not platform-dependent, so it wouldn't break on one vs another machine. I suggest closing this issue
from odin.
omnisci3nce
commented on September 18, 2024
It is confusing that when you use
FOO :: Foo.A
at the top level, when statements in all files work, but when you swap to the following
when ODIN_OS == .Linux {
FOO :: Foo.A
} else {
FOO :: Foo.B
}
it suddenly stops working in those other files saying that FOO is undeclared. I think it should at least have a more descriptive error.
from odin.
Related Issues (20)
- (BUG) Compiler crash (.cpp assertion) due to non-exact integer value from casting HOT 1
- (BUG) Compiler crash with three errors on math.odin source code associated with truncation of the math.odin code literals HOT 2
- Frequent compiler crash Segmentation fault: 11 on macOS HOT 4
- compiler panics with os.Errno
- Implicit conversion at union initialization (not distinct enough) HOT 3
- net.listen_tcp return connected port selected by os when port number was 0
- Compiler assertion error when proc group is used as a callback argument HOT 1
- Incorrect debug info generation for bitfields.
- Switch statement not type-checking
- Missing error for sole declaration in a case block of the switch statement
- Compiler silently fails when output file isn't writeable.
- Compiler ignores `distinct` for generic types
- Calculated default polymorphic const of a struct is incorrect
- Parapoly struct alias is broken when both types are in same package
- `sync.atomic_add()` causes LLVM code gen failure when using non-integer types
- Json should allow a way to specify how to marshal/unmarshal an object (e.g. encoding/uuid) HOT 2
- `linux.ptrace(linux.PTRACE_CONT, ...)` returns `EIO` every time HOT 3
- `wgpu` vendor library fails on windows due to linking error HOT 1
- `core:os` package `read_entire_file_xxx` procedures don't work on `/proc` filesystem even if on a Linux system HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from odin.