Giter Club home page Giter Club logo

Comments (2)

Kelimion avatar Kelimion commented on July 19, 2024

Interesting. The previous fix did indeed fix the examples given there:

	s := []int{2,2,2}
	res := slice.unique(s)
	assert(slice.equal(res,[]int{2}))

	res = slice.unique([]int{1,1,1,2,2,3,3,3,3})
	assert(slice.equal(res, []int{1,2,3}))

	res = slice.unique_proc([]int{1,1,1,2,2,3,3,3,3}, proc(a, b: int) -> bool {
		return a == b
	})
	assert(slice.equal(res, []int{1,2,3}))

But I can also reproduce the bug you found using that old fix.
I'll have a look at your fix momentarily and will write more extensive test coverage for tests/core/slice.

from odin.

Kelimion avatar Kelimion commented on July 19, 2024

Fixed by #3770.

from odin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.