Odata returns generic type error when enum is a key about odata.net HOT 14 CLOSED

Yes, we should support enums as keys.

@gathogojr -- Note: that the code shown above as the current logic in the first block is slightly different than what I see in the repo.

In the repo, the conditional check is:

                if (!PrimitiveType.IsKnownType(key.PropertyType) && !(key.PropertyType.GetGenericTypeDefinition() == typeof(System.Nullable<>) && key.PropertyType.GetGenericArguments().First().IsEnum()))

which is different than above reported code in that:

1. the IsEnum check is on keyProperty.PropertyTypeGetGenericArguments().First().IsEnum(), rather than keyProperty.PropertyType.IsEnum()
2. the IsEnum check is grouped with the GetGenericTypeDefinition() check rather than a separate check

I suspect the reason that the fixed code doesn't throw is not because of ordering, or even grouping, but because it doesn't call GetGenericArguments.

I'm not sure the rationale behind the existing logic that would make us think that an unknown type must be generic (or why we specifically check for an enum if it is), but if we don't know for sure that key.PropertyType is generic we should check IsGenericType before calling GetGenericTypeDefinition or GetGenericArguments.

from odata.net.

I'm also encountering the same issue when attempting to access the Microsoft Business Central API through OData V4. We're using the latest Microsoft.OData NuGet packages, 7.21.1. Any attempt to enumerate a collection with an enum key returns the error about generic types, even when trying to project to a new class.

from odata.net.

To expand on the above, it looks like the Business Central API converted quite a few string to Enums. The ItemReference class uses an Enum as a key field and we're getting the error in GetKeyProperties().

from odata.net.

@mikepizzo Yes the problem seems to be that GetGenericTypeDefinition is called too early. The code should accept simple types and enums as valid keys and reject generic types. So changing the ordering of the if statement ensures that GetGenericTypeDefinition isn't called if the key is an enum. Can we contribute on this issue by creating a pr to fix this?

from odata.net.

Any news on this?
We're having the same problem when using Odata together with Business Central

from odata.net.

We used a work around by selecting odatakeys and not selecting the enum key fields. https://www.cloudfronts.com/blog/d365-business-central/using-odatakeyfields-for-fetching-records-in-business-central-web-services/

from odata.net.

Sadly that isn't going to work for me.
I'm getting the error when running this code
var linesQuery = new DataServiceCollection<MtSalesInvoiceLine>(_mtApiContext.MtSalesInvoiceLines.AddQueryOption("$expand", "dimensionSetLines").Where(s => s.DocumentId == salesOrder.Id));

There's an enum key field somewhere in the hierarchy.

Will update when I find a solution though

from odata.net.

Found out my error was due to breaking changes being introduced on Business Centrals side with version "24.1.18927.19282". Running the same code towards an Business Central Cloud environment running "24.0.16410.17628" succeeds.

from odata.net.

@MikkelGlerup , do you have a link to the breaking change?

from odata.net.

@nmushovic I made my own issue and gave it more details here

EDIT:
I was wrong, it had nothing to do with version

from odata.net.

Hello, can someone to aprove this fix: #3013
It is critical because our app which communicates with MS Bussiness Central does not work after new API definition with enums was updated.
@gathogojr @habbes @xuzhg @ElizabethOkerio @paulodero
Thank you very much.

from odata.net.

from odata.net.

@mikepizzo It looks fine now.

from odata.net.

Do you know when a new version with a fix for this bug will be released?

from odata.net.