Giter Club home page Giter Club logo

Comments (8)

burnout87 avatar burnout87 commented on August 30, 2024 2

Quickly verified now and some tests are no longer succeeding. Will provide a fixing PR.

from dispatcher-plugin-integral.

burnout87 avatar burnout87 commented on August 30, 2024 1

we need to be sure that the defaults match those in frontend. Do they?

Not at that moment. I will adapt!

from dispatcher-plugin-integral.

volodymyrss avatar volodymyrss commented on August 30, 2024 1

I already made an issue for another one oda-hub/dispatcher-plugin-integral-all-sky#12
Not all will be affected.
This mostly matters for the one with URL. But it might change something due to new defaults

from dispatcher-plugin-integral.

burnout87 avatar burnout87 commented on August 30, 2024

Ok, something is missing: besides setting the default values for the parameters for the specific requested query, also those for the instrument_query and src_query should be set.

Because of that a jemx test is not passing.

Dedicated PR coming soon.

from dispatcher-plugin-integral.

volodymyrss avatar volodymyrss commented on August 30, 2024

we need to be sure that the defaults match those in frontend. Do they?

from dispatcher-plugin-integral.

ferrigno avatar ferrigno commented on August 30, 2024

It might be related to this work in progress, but I submitted three requests for jobs that should have been already done
I received a submission email, but never a done email.
The first request was delivered in a few seconds, the others took several minutes (actually the last one is still in progress)
[ODA][submitted] isgri_spectrum first requested at 2021-09-24 14:22:04 job_id: eef3e3be
[ODA][submitted] isgri_spectrum first requested at 2021-09-24 14:24:34 job_id: c1beaf6c
[ODA][submitted] isgri_spectrum first requested at 2021-09-24 14:42:05 job_id: 38bccebb

from dispatcher-plugin-integral.

volodymyrss avatar volodymyrss commented on August 30, 2024

It might be related to this work in progress, but I submitted three requests for jobs that should have been already done
I received a submission email, but never a done email.
The first request was delivered in a few seconds, the others took several minutes (actually the last one is still in progress)
[ODA][submitted] isgri_spectrum first requested at 2021-09-24 14:22:04 job_id: eef3e3be
[ODA][submitted] isgri_spectrum first requested at 2021-09-24 14:24:34 job_id: c1beaf6c
[ODA][submitted] isgri_spectrum first requested at 2021-09-24 14:42:05 job_id: 38bccebb

this work in progress is not merged and hence is not related https://github.com/oda-hub/doc-review-guidelines/issues/66

from dispatcher-plugin-integral.

burnout87 avatar burnout87 commented on August 30, 2024

Not really related to this plugin, but should the same test be performed also for other plugins (eg antares)?

from dispatcher-plugin-integral.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.