Support injection of HttpClient instances about octokit.graphql.net HOT 8 CLOSED

Cool, I'll give that a whirl when I get next a spare hour or so.

from octokit.graphql.net.

We are pretty interactive...
If you start me off with a unit test that shows us what you are thinking...
I can either take over or point you in the right directions to finish.

from octokit.graphql.net.

Yup.

from octokit.graphql.net.

That is a very good suggestion.

from octokit.graphql.net.

Would an additional ctor implemented like this be sufficient?

public Connection(HttpClient client, Uri uri, ICredentialStore credentialStore)
{
    Uri = uri;
    CredentialStore = credentialStore;
    HttpClient = client;
}

from octokit.graphql.net.

Maybe also one where the Uri isn’t required, given that I guess that exists just for Enterprise? The code would also need to add the UserAgent if not already present, or would you just leave that completely up to the integrator?

Happy to submit a PR if there’s a rough approach agreed.

from octokit.graphql.net.

Have opened #131 with some very basic changes to Connection with a test showing the sort of things that can be achieved by supporting HttpClient injection.

from octokit.graphql.net.

I guess this is closed now #131 is merged? 😺

from octokit.graphql.net.