Giter Club home page Giter Club logo

Comments (5)

ocombe avatar ocombe commented on May 12, 2024

Hi, could you do me a plunkr with the bug in question so that I can check if your hotfix is the right solution ?

from oclazyload.

hlege avatar hlege commented on May 12, 2024

http://plnkr.co/edit/HjbEEigCaLrdqgR4JpZ6?p=preview
change the oclazyload_bug.js to oclazyload.js to see the fix.

Note: in the source code lot of ";" missed at the end of function.

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

Thanks, I'll take a look at it this afternoon

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

Ok I found the problem, we add the required modules foo, bar & bar2 to the "to-load" modules list, but then for each module we add also load the dependencies.
We will load in reverse order bar2 (no dependency), bar (no dependency), foo: 2 dependencies bar & bar2 that we will load again.
I need to make sure that we don't load those multiple times in the same loading batch.

The fix is a bit more complicated than your hot fix because we need to take into account that sometimes people want to reload the config/run functions of those modules.

I think that I know how to fix it but I have to make more test to be sure that I don't break anything. Anyway, thanks for the report ! I'll let you know once it's fixed.

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

It's fixed in 0.3.7 !

from oclazyload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.