Comments (5)
Hi, could you do me a plunkr with the bug in question so that I can check if your hotfix is the right solution ?
from oclazyload.
http://plnkr.co/edit/HjbEEigCaLrdqgR4JpZ6?p=preview
change the oclazyload_bug.js to oclazyload.js to see the fix.
Note: in the source code lot of ";" missed at the end of function.
from oclazyload.
Thanks, I'll take a look at it this afternoon
from oclazyload.
Ok I found the problem, we add the required modules foo, bar & bar2 to the "to-load" modules list, but then for each module we add also load the dependencies.
We will load in reverse order bar2 (no dependency), bar (no dependency), foo: 2 dependencies bar & bar2 that we will load again.
I need to make sure that we don't load those multiple times in the same loading batch.
The fix is a bit more complicated than your hot fix because we need to take into account that sometimes people want to reload the config/run functions of those modules.
I think that I know how to fix it but I have to make more test to be sure that I don't break anything. Anyway, thanks for the report ! I'll let you know once it's fixed.
from oclazyload.
It's fixed in 0.3.7 !
from oclazyload.
Related Issues (20)
- Thank you HOT 1
- Added new link to ADVANCED USAGE section HOT 2
- Lazy-load MonacoEditor, which has an AMD loader
- AngularJS: Broken lazy loaded modules on state removal HOT 1
- [Web pack with ocLazyLoad] Fails to load the controller and template
- How it should work with unit-tests? HOT 2
- problem in angular 1.7.2 HOT 3
- Module's config loaded via ocLazyLoad is not getting called HOT 2
- Confused to attach dynamic controller into template view
- Can't use within app config HOT 1
- URL Parameters stay empties HOT 2
- Error: Load timeout for modules: ../d3.v2.js
- Lazyloading controllers - Not working HOT 1
- serie = true not working HOT 1
- Is the project dead? HOT 2
- Examples don't run
- How to lazyload typescirpt modules with oclazyload in AndularJs 1.5+ and ui-router?
- ocLazyLoad with Karma and Webpack HOT 2
- High Security issue XSS on ocLazyLoad 0.5.2 at 235 line HOT 1
- Change name or location of lazy chunks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oclazyload.