Giter Club home page Giter Club logo

Comments (11)

TimNZ avatar TimNZ commented on May 12, 2024

+1, broken in 0.3.0

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

Ok, do you have the message of the exception ?
Do you use the internal js loader, requirejs or script.js ?
Are module1 and module2 independant or do one of them require the other one ?

from oclazyload.

mort3za avatar mort3za commented on May 12, 2024

unfortunately i can't see that situation again and i didn't saved it but i am sure changing plugin file was source of error.
error was something like module undefined is not available... seemed it was related to name of modules.

from oclazyload.

TimNZ avatar TimNZ commented on May 12, 2024

In my case I simply replaced 0.2.0 with 0.3.0 and it started failing.

Since I'm on a time crunch with a project I reverted to 0.2.0, and since 0.2.0 works I don't have a compelling reason to actually upgrade to 0.3.0, I'll have another look after release in a week or so.

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

Ok thanks !

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

You should check if it was the same bug as #33 fixed in release 0.3.1

from oclazyload.

TimNZ avatar TimNZ commented on May 12, 2024

Still broken.

The files are being loaded but do not appear to be evaluated/executed properly.

Still in the middle of prep for release so won't look at it again till at least next week, thankfully 0.2.0 works fine.

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

Damn :-(

from oclazyload.

taz avatar taz commented on May 12, 2024

I've spent a bit of time looking at this and the only place I could reproduce any sort of error was using IE in ie8 emulation mode, where it kicked up a stink about the trailing comma in the original post.

I'm sceptical as to whether that's the actual problem though or just an issue with the example given. It didn't occur in 0.2.0 though, only 0.3.0, so you never know!

Either way, I've put in a quick fix to handle when the module being passed to the loader is undefined or null. I'm still testing a couple of other bits, then I'll issue a PR.

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

Awesome, thanks ! Take your time, we're all doing this for the community. Thanks again for your help.

from oclazyload.

ocombe avatar ocombe commented on May 12, 2024

@TimNZ & @mort3za can you try the current master (it's not a release yet) and see if the PR from @BenBlazely fixes your problems ?

from oclazyload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.