Comments (10)
Hi Kitti,
other improvement list :
- Customised validation error messages - Business Messages rather than the system ones
- Also, can this be worked along side with base_exception OCA module..? Some of the functionality seems to be an overlap.
-Naran
from server-ux.
Sure. But can you explain more. Especially on point 2.
from server-ux.
@nmoturi I added the improvements in the list.
from server-ux.
Among the above enhancement, I think the "Replace notification system tray, with Odoo's Activity infrastructure" is quite harsh and need more opinions.
Functionally, I think it make sense, as the tray came before activity, and once we have activity, it is more unified.
@LoisRForgeFlow do you have comment on this?
from server-ux.
@kittiu why do you want to use activities? activities are not persistent and serve for many things, can't the tier validation get very diluted in activities systray?
Regarding the other items in the list and also continuing my answer in this other PR, I think you can propose everything that are fixes or soft improvements (not important changes in data model) to base_tier_validation and start new submodules (base_tier_validation_*) for bigger improvements. Then we add a section in the settings wizard on base_tier_validation to highlight and give visibility to those improvements.
I think this is the best way to go as I am not able to follow you up on all your proposed changes as much as I would like and I apologize for that. Yet, being realistic it is the best way for you to get job done and code merged quicker.
from server-ux.
@LoisRForgeFlow thank you for your comments. Please no apologize, it is me to apologize. I saw you were super busy with other projects.
I am comfortable with the splitting module and the settings wizard. 👍
from server-ux.
@LoisRForgeFlow - The idea of using the activity groups is to avoid a single person dependent. As an example for a large volume of approvals not everything can be done by a single person, anyone with in the activity group can be approved..
Thanks,
Naran
from server-ux.
@nmoturi Thank you for comment. The point that activity is not persistent is valid. The way systray works now is, it lively query on what todo for the login user, while the activity is just a created record, and so it can get diluted per say.
For your point of single person dependent. If you could explain here too in more detail.
from server-ux.
@kittiu
On a document with many states with branch flow such as a Sale Order, it is a good idea if tier_validation can provide minimal 2 steps. (step 1 _from_state _to_state and then step 2 __from_state.. _to_state...) For example on a quotation or sales order document. Sometimes there is a need to review the quotation before it can be sent or printed for a customer. Once step 1 is ok the quotation can be sent to the customer and may have some changes due to negotiation etc, but once it is sent the second step then become active to prevent the modified quotation data confirmed without review.
from server-ux.
@kittiu
On a document with many states with branch flow such as a Sale Order, it is a good idea if tier_validation can provide minimal 2 steps. (step 1 _from_state _to_state and then step 2 __from_state.. _to_state...) For example on a quotation or sales order document. Sometimes there is a need to review the quotation before it can be sent or printed for a customer. Once step 1 is ok the quotation can be sent to the customer and may have some changes due to negotiation etc, but once it is sent the second step then become active to prevent the modified quotation data confirmed without review.
Just in case it may help, let me mention this state machine implementation for Odoo by Acsone https://github.com/acsone/scobidoo
from server-ux.
Related Issues (20)
- Adding batch for server_action_mass_edit HOT 3
- [14.0] [base_tier_validation] Field validate_by incompatible with fields reviewer or reviewer_group or reviewer_field HOT 1
- Unable to install module "base_binary_url_import" and "Test Base Binary URL Import" HOT 1
- [16.0][mass_editing] Action "Mass Edit" doesn't appear in "Server Actions" or in Actions during objects choosing HOT 3
- [16.0] date_range lost compatibility with web_advanced_search HOT 2
- date_range module causes error when selecting a json type field HOT 6
- base_tier_validation: wrong counter for pending review HOT 1
- [15.0] Branch tests are broken HOT 1
- Migration to version 17.0 HOT 14
- [RFQ][base_revision] add a module base_version HOT 2
- error in installing date_range version 17 HOT 1
- [15.0] [base_revision] add client_order_ref to the fields that get copied to new revision
- [16.0] [base_tier_validation] Incorrect timezone for Validation Date in Tier Review HOT 1
- [14.0] date_range : date range generator ask for end date even if it's already filled
- [16.0+] base_tier_validation: Selection Field not translated. HOT 3
- base_tier_validation: Missing field "need_validation" in form-embedded lists HOT 2
- base_tier_validation: blocking notifications cron, a.k.a. should it block sudo writes? HOT 4
- [16.0][base_tier_validation] Make "full" form readonly optional HOT 2
- [17.0][base_tier_validation] Some modules have inconsistent states, some dependencies may be missing: ['base_tier_validation'] HOT 2
- New tier validation record create with origin tier validation has comment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from server-ux.