Giter Club home page Giter Club logo

Comments (7)

pedrobaeza avatar pedrobaeza commented on June 15, 2024

Should we close this?

from product-attribute.

lasley avatar lasley commented on June 15, 2024

Yup seems like nobody cares. We'll leave it in medical!

from product-attribute.

lukebranch avatar lukebranch commented on June 15, 2024

@lasley @pedrobaeza ,

I only just came across this RFC, however I can definitely see how this would be incredibly useful for food service companies, or perhaps chemical manufacturing companies that may have specific storage requirements. I definitely see this module being very useful outside of the scope of the medical vertical.

I currently have a use case for this module with a food & beverage distribution company. They sell a wide range of products ranging from dry-aged beef and wines, through to fruits and vegetables. They could definitely find a use for providing specific instructions and inventory locations for storage.

For example, dry aged beef needs to be stored at a constant ~4°C and around 85% humidity, while different wine varietals and vintages will have different storage requirements.

In a similar manner if you're selling avocados and bananas, you will have specific storage instructions and requirements for these, perhaps also specifying a stock location that is entirely separate for the two so that they don't interact and spoil.

In my humble opinion, I think this should be re-opened, as the module has a wide number of use cases outside of vertical-medical.

from product-attribute.

lasley avatar lasley commented on June 15, 2024

@lukebranch - Thanks for the elaboration. This was indeed the use case I was thinking of when I submitted this RFC. Reopening.

I'll tailor & submit the module upstream at some point soon, but feel free to escalate the process by bringing it over yourself 😄 - https://github.com/LasLabs/vertical-medical/tree/release/10.0/medical_medicament_storage

Medicaments are a direct inherit from product, so changes should be incredibly minimal.

from product-attribute.

lukebranch avatar lukebranch commented on June 15, 2024

@lasley,

Thanks for reopening this. I may look into doing this next weekend depending on my schedule.

If I was to make a PR, the module name should be product_storage_instruction right?

from product-attribute.

lasley avatar lasley commented on June 15, 2024

@lukebranch - Yup I think that's a good name for it. product_storage may hit the intent too & be a little more concise.

from product-attribute.

github-actions avatar github-actions commented on June 15, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from product-attribute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.