patch disappeared from hr_payroll_extension: is that intentional? about hr HOT 18 CLOSED

Could you be more specific?

from hr.

For V7.0, on 09/28/2013 the folder "patches" under "hr_payroll_extension" was deleted.

from hr.

That 's commit a314d8e by @max3903 .
Maybe he can help.

from hr.

I understand that the folder "patches" does not have its place in the OpenERP's Module Folder Structure.
What i want to know is, if the patch is still necessary to make the module work properly, this should be at least, clearly indicated in the manifest file (@ the 'description' section), and put a link to the patch file.

from hr.

Hi @max3903. Was that patch removed intentionally in a314d8e or is it a faulty merge? Thanks!

from hr.

@bwrsandman @max3903 Was the patch obsolete?

from hr.

I can't speak as to why it was deleted, but I don't see why the changes in the patch couldn't be done as a module...

We should not encourage patching the server.

from hr.

@diassynthesis Do you think we can close this?

from hr.

Not yet please. I've posted a message at http://miketelahun.wordpress.com and i'm waiting for a reply

from hr.

If @miketelahun should comment on this, it's best to just mention him as I just did.
I've just reviewed the diff, it's related to the "Need Action" mechanism, not to HR or Payroll.

So it definitely shouldn't be in the module.
I guess I can answer your question: it's not needed.

from hr.

@dreispt Yes, you can close this issue. Just another question (not directly related to this branch, but related to the hr_payroll module): Could you please take a look at odoo/odoo#3916 and tell me what you think about the last lines of the "hr_payroll-hr_payroll.patch".Thank you and best regards.
NB: The related patch is "hr_payroll-hr_payroll.patch"and not the "openobject-server-openerp-addons-base-ir-ir_ui_menu.patch".

from hr.

The file removed in a314d8e is not necessary, as it relates to a useability improvement for ir.need_action

from hr.

Thank you, but are you talking about "openobject-server-openerp-addons-base-ir-ir_ui_menu.patch" or "hr_payroll-hr_payroll.py-patch", or both.

from hr.

I am talking about openobject-server-openerp-addons-base-ir-ir_ui_menu.patch

On 12/13/2014 03:21 PM, diassynthesis wrote:

Thank you, but are you talking about
"openobject-server-openerp-addons-base-ir-ir_ui_menu.patch" or
"hr_payroll-hr_payroll.py-patch", or both.

—
Reply to this email directly or view it on GitHub
#19 (comment).

from hr.

What about the "hr_payroll-hr_payroll.py-patch".

from hr.

Still waiting for a response about "hr_payroll-hr_payroll.py-patch". About odoo/odoo#3916 , solved but !!! a new bug revealed odoo/odoo#4363

from hr.

OCA modules shouldn't have bug patches in them.

If you have a bug, open an Odoo issue. For community maintained patches, look at the OCA/OCB project. You can also file the Issue there, but I believe an OCB PR would also be expected. In case you are not able to provide a fix yourself, my honest advice is to seek expert help.

This issue should be closed, since bug fixes are out of scope for OCA modules.

from hr.

@dreispt That's what I've said in my third comment. I will close this issue at the end of this comment. @miketelahun I just want to know, if the "hr_payroll-hr_payroll.py-patch" is needed or not ? Thank you and best regards.

from hr.