Giter Club home page Giter Club logo

Comments (10)

ivantodorovich avatar ivantodorovich commented on July 19, 2024 2

Ok then, I trust your call :) PR looks good to me

from fleet.

mamcode avatar mamcode commented on July 19, 2024 1

Thanks for open this issue @marcelsavegnago I think that the field stage_id should not be removed, but it should be removed from the statusbar, perhaps an option can be to add stage_id as one field in the form view. In any case, let's wait for the opinion of @ivantodorovich who has a better functional knowledge of this module with some clients.

from fleet.

marcelsavegnago avatar marcelsavegnago commented on July 19, 2024 1

I did not leave it editable in the form but I agree that it is necessary.

from fleet.

marcelsavegnago avatar marcelsavegnago commented on July 19, 2024

We can even continue with both fields. However, it can be a little redundant.
In addition, if we keep both fields, we need to define what the service status bar should look like.

image

from fleet.

marcelsavegnago avatar marcelsavegnago commented on July 19, 2024

In that case, we can consider dividing this module and generating other modules such as fleet_vehicle_service_tags.

from fleet.

marcelsavegnago avatar marcelsavegnago commented on July 19, 2024

image

@mamcode what do you thing?

cc @ivantodorovich

from fleet.

mamcode avatar mamcode commented on July 19, 2024

image

@mamcode what do you thing?

cc @ivantodorovich

I see it fine but how can the user change the stage? Is it editable in form ?

from fleet.

ivantodorovich avatar ivantodorovich commented on July 19, 2024

Hello !

I agree it should be editable :)
The badge looks good but it may be confusing. What about a regular m2o field? That way we get the label, which might be easier for the user to understand

I haven't really analyzed the core module in 14.0 yet, it's possible our customer requirement may be satisfied with the new core workflow (using state field).

@marcelsavegnago how are you using this module?

from fleet.

marcelsavegnago avatar marcelsavegnago commented on July 19, 2024

Hello !

I agree it should be editable :)
The badge looks good but it may be confusing. What about a regular m2o field? That way we get the label, which might be easier for the user to understand

I think it is worth using a regular m2o field.

I haven't really analyzed the core module in 14.0 yet, it's possible our customer requirement may be satisfied with the new core workflow (using state field).

I believe that the state field serves despite the loss and flexibility offered by stage_id.

@marcelsavegnago how are you using this module?

At the moment I am not using it on any client but I was considering using it on a specific project for vehicle fleet management.

from fleet.

mamcode avatar mamcode commented on July 19, 2024

@ivantodorovich @marcelsavegnago I think that we can close this issue.

from fleet.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.