[13.0] product_brand poor performance when having many (250k) products about brand HOT 9 CLOSED

Probably... Usual optimization techniques are read_group or search_count.

from brand.

Probably... Usual optimization techniques are read_group or search_count.

Thanx for quick reply. Would you please care to elaborate a bit on how to apply the mentioned? The _compute_products_count only does this:

    @api.depends("product_ids")
    def _compute_products_count(self):
        for brand in self:
            brand.products_count = len(brand.product_ids)

I'd thought this would produce simple SQL query but obviously it is doing something more. I guess from the time it takes it somehow does a query for each Product with that Brand applied. Should I maybe use search_count in this method instead of what is there currently?

from brand.

It's caching all products data (more or less). You can do something similar (simpler in this case) to:

https://github.com/OCA/contract/blob/4db5c90a1d26c3ac5567f756e35839c4ee3d9492/contract/models/res_partner.py#L24-L39

from brand.

It's caching all products data (more or less). You can do something similar (simpler in this case) to:

https://github.com/OCA/contract/blob/4db5c90a1d26c3ac5567f756e35839c4ee3d9492/contract/models/res_partner.py#L24-L39

Yes but that's reading the objects and actually using them. AFAIK I do not need to load them just count them. So I guess I should use search_count in _compute_products_count implementation? Will try.

from brand.

Thanx @pedrobaeza The solution is quite simple. I create a module where I overrode the method to be like this:

class ProductBrand(models.Model):
    _inherit = "product.brand"

    @api.depends("product_ids")
    def _compute_products_count(self):
        contract_model = self.env['product.template']
        for brand in self:
            brand.products_count = contract_model.search_count([('product_brand_id', '=', brand.id)]) 

Is that correct?

from brand.

Yes, that's it

from brand.

Was asking just to be sure I do not miss anything. Does it make any sense to create PR and change the main module with this code?

from brand.

Yes, please go with the pr

from brand.

OK, will. Thanx for help, closing this one.

from brand.