[8.0] [account_payment_return] Duplicated journal item about account-payment HOT 5 CLOSED

cc @carlosdauden

from account-payment.

I've been trying out different scenarios and I think the module should be set to Not installable until this is fixed.

If you create a new return for two invoices of the same partner, it does not matter whether you put it in the same line or in two different lines. When you put it in two different lines, apparently everything seems OK, but those two invoices stay related (they're reconciled together) and if you try to register a payment later the invoices will not be marked as paid.

If you try to pay two invoices of the same partner, return them, and then mark them as paid again, you will see what I am talking about.

It was a pain to reverse everything that was done by the return, that's why I suggest to set it to Not installable.

from account-payment.

Your case is very specific (same partner in several payments), so no reason for disable it. You can also fix it and propose the patch in a PR.

from account-payment.

Thank you Pedro, I'll take a look at the code and see what I can do (I'm a noob in Python)

from account-payment.

Closing due to aging.

from account-payment.