Giter Club home page Giter Club logo

Comments (9)

kharanenka avatar kharanenka commented on June 5, 2024 1

We will be glad if you make PR with implementation of this feature.

from oc-toolbox-plugin.

SebastiaanKloos avatar SebastiaanKloos commented on June 5, 2024

@kharanenka Or should a new event be better in this situation?

from oc-toolbox-plugin.

kharanenka avatar kharanenka commented on June 5, 2024

Hi @SebastiaanKloos ! What changes are you talking about? Can you give some example with "preview_image" field?

from oc-toolbox-plugin.

SebastiaanKloos avatar SebastiaanKloos commented on June 5, 2024

@kharanenka hi! Yes you can see my plugins repo https://github.com/kloos-dev/oc-importshopaholic as example of what I would like to do with the preview_image.

The logic is in this file: https://github.com/kloos-dev/oc-importshopaholic/blob/master/classes/item/ImportValue.php

from oc-toolbox-plugin.

kharanenka avatar kharanenka commented on June 5, 2024

I think that file uploads should be implemented in main plugin. It makes no sense to move this into separate plugin. We are planning to make this feature in main plugin.

from oc-toolbox-plugin.

SebastiaanKloos avatar SebastiaanKloos commented on June 5, 2024

We will be glad if you make PR with implementation of this feature.

No problem at all. I can make a pr ready by tomorrow. The reason why I created a new plugin was that I needed the functionality last week😬

from oc-toolbox-plugin.

kharanenka avatar kharanenka commented on June 5, 2024

It is good news! Thanks

from oc-toolbox-plugin.

SebastiaanKloos avatar SebastiaanKloos commented on June 5, 2024

Created a pr #94

from oc-toolbox-plugin.

vshepel avatar vshepel commented on June 5, 2024

We will be glad if you make PR with implementation of this feature.

How much more to wait before the implementation of this pr? We really need a similar functionality!

from oc-toolbox-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.