Giter Club home page Giter Club logo

Comments (13)

obukhow avatar obukhow commented on August 12, 2024

Ok, I'll do this as soon as possible

from adaptiveresize.

leonsmith avatar leonsmith commented on August 12, 2024

Much appreciated. I have since bundled this into my own application so will contribute a few changes back

from adaptiveresize.

obukhow avatar obukhow commented on August 12, 2024

How did you find this repo?

from adaptiveresize.

leonsmith avatar leonsmith commented on August 12, 2024

I was searching for "adaptive resize magento" in google to see if anyone else had posted any comments relating to the original article I wrote.

from adaptiveresize.

obukhow avatar obukhow commented on August 12, 2024

You propogate bad practices of conding by allowing people to reload magento core classes :) Why don't you just create a module and allow them to install it in a few clicks? Anyway nobody can understand this resizing magic :)

from adaptiveresize.

leonsmith avatar leonsmith commented on August 12, 2024

I understand now it's not the best method and there are tons of bugs in the original source code (if the source image is smaller than the target image it throws an exception) but this was code i wrote after building my first magento website (over 2 years ago) when I didn't understand the context and usefulness of Modules and ducktyping existing classes.

from adaptiveresize.

obukhow avatar obukhow commented on August 12, 2024

Oh, really long ago. You are working as a freelancer or in a development company?

from adaptiveresize.

leonsmith avatar leonsmith commented on August 12, 2024

I work for an agency called FARM now, but at the time I worked for 2amMedia :)

from adaptiveresize.

obukhow avatar obukhow commented on August 12, 2024

I thought you are a profecional e-commerce developer, but these sites looks to awesome :) Looks like a design agency

from adaptiveresize.

leonsmith avatar leonsmith commented on August 12, 2024

Thank you :)

I have uploaded my new revised code, packaged as module if you want to take a look Magento Adaptive Resize

from adaptiveresize.

obukhow avatar obukhow commented on August 12, 2024

Ha-ha :) Become much smaller :)

from adaptiveresize.

leonsmith avatar leonsmith commented on August 12, 2024

Yep! Things get a lot easier when you know what your doing! Thank you for the credit :)

from adaptiveresize.

obukhow avatar obukhow commented on August 12, 2024

But now I have to still the new code :)

from adaptiveresize.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.