Comments (3)
Thanks for opening this issue, this is indeed a bug!
Did you encounter this while attempting an operation with a Michelson address in binary format or were you inspecting code? The reason I ask - tezos-client
only prepares addresses as ASCII so we aren't aware of a real world instance where this code is used.
As we think about the best solution for this, if the code is dead in practice since only ASCII is used, the best solution could be to remove it and avoid the unnecessary feature (and the testing challenges that come from not being able to create binary formatted addresses from tezos-client).
Additional feedback on how you encountered this will help us make the right decision here. This will most likely be done as part of a batch of changes, whenever that may be. Thanks again!
from ledger-app-tezos.
Did you encounter this while attempting an operation with a Michelson address in binary format or were you inspecting code?
Thanks for your quick reply! I am working on a fuzzing+code coverage tool and wanted to test it on some Ledger Nano applications. I found this bug while investigating why some lines of code appeared to never be reached according to the code coverage report. So I do not know whether a real Tezos transaction runs the buggy code path.
from ledger-app-tezos.
Hello,
While reading the state machine insrc/operations.c
I am wondering how this code works:ledger-app-tezos/src/operations.c
Lines 199 to 213 in 58797b2
More precisely after
case 0: ... state->address_step=1;
andcase 1: ... state->address_step=2;
, why is there nostate->address_step=3;
on line 209, at the end ofcase 2:
? The case block "falls through" intocase 3
and then the function returns inCALL_SUBPARSER
(line 212). When I add someprintf
statements in this function to analyze where the flow goes, it seems that the "subparsing" goes back to line 207 instead of line 212 and that the code in lines 213-215 is never executed. Did I understand the code correctly or did I miss something?
tz1dk5tsD3vr1ib7XY2CULdWa81vMBbVbjDj
from ledger-app-tezos.
Related Issues (20)
- Tezos Ledger Nano S KT wallet withdrawal issue HOT 6
- Broken link in readme HOT 1
- Possibility to bake with several keys of the same Ledger HOT 5
- Signing arbitrary byte sequences HOT 9
- Acces curve bip25519 accounts using ledger live/tezbox or any other online wallet with ledger nano S. HOT 2
- why re-enter pin when leaving the app? HOT 2
- Compile problem HOT 1
- "This app is not genuine" HOT 4
- Improve "Unrecognized Operation" messages for Transfers with params and batch transfers HOT 6
- Support: Windows Subsystem for Linux WSL Ledger USB Support HOT 1
- Nano X v.2.2.9: Tezos Wallet Bluetooth not working properly HOT 1
- Allow the use of tz2 addresses HOT 3
- Allow the exportation of extended public key HOT 3
- Example APDU for using INS_SETUP HOT 1
- Example APDU for INS_SETUP HOT 2
- tz1dk5tsD3vr1ib7XY2CULdWa81vMBbVbjDj
- Ledger Blue support
- Incorrect fee for a transaction
- Post Babylon: When trying to confirm transfer of XTZ from my kt1 to tz1 account, Ledger displays "Unrecognized Operation / Sign Hash" message HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ledger-app-tezos.