Giter Club home page Giter Club logo

Comments (22)

ArneNostitz avatar ArneNostitz commented on July 22, 2024 1

(and sorry if my comment earlier was sounding rude - its just very scary if a plugin deletes files from the server. wasnt meant to sound rude in any way ... its amazing what you do and i really have the most respect for anything that all you amazing plugin people do!!! this is really the coolest community and i am super thankful, that you are so responsive and made this plugin in the first place!!)

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

1/ I need your configuration and plugin version. This bug must be fixed in the late version (4.11.16)
2/ You can disable auto-clean
3/ You can revert the PR to restore your file.

this is not working reliable - and deleting files is fatal!!

This is pretty disrespectful to say on a plug-in coded by an alone people for free.

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

Plugin Version was 4.11.15rc4; but auto-clean was off

ill check again with the current version

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

Again, I need a data.json configuration, the repo where you tried to upload and a example note.

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

with the newest version it does not find changes and new files when hitting "Refresh published and upload new notes"

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

{
"githubRepo": "",
"githubName": "
",
"GhToken": "***",
"githubBranch": "main",
"shareKey": "share",
"excludedFolder": [],
"fileMenu": true,
"editorMenu": true,
"downloadedFolder": "fixed",
"folderDefaultName": "Obsidian/Arne",
"yamlFolderKey": "",
"rootFolder": "",
"workflowName": "",
"embedImage": true,
"defaultImageFolder": "",
"autoCleanUp": false,
"autoCleanUpExcluded": [],
"folderNote": false,
"folderNoteRename": "index.md",
"convertWikiLinks": false,
"convertForGithub": false,
"subFolder": "",
"embedNotes": false,
"copyLink": false,
"mainLink": "",
"linkRemover": "",
"hardBreak": false,
"logNotice": false,
"convertDataview": false,
"useFrontmatterTitle": false,
"censorText": [],
"inlineTags": false,
"dataviewFields": [],
"excludeDataviewValue": [],
"metadataFileFields": [],
"frontmatterTitleKey": "title",
"shareExternalModified": false,
"automaticallyMergePR": true,
"metadataExtractorPath": "",
"convertInternalNonShared": false,
"frontmatterTitleRegex": "",
"frontmatterTitleReplacement": "",
"ExcludedFolder": []
}

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

with the newest version it does not find changes and new files when hitting "Refresh published and upload new notes"

Try to force re-upload, then.

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

uploading single files does work. just the other command is not ... says "no new files"

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

It's pretty strange that it deleted file if you use the fixed repository.... I need to check in the code, then

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

How works the upload all commands?

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

i added a few files without the "share" tag manually (as i have a few hundred files and open one by one adding yaml is timeconsuming for those old files) ... upload all tried to delete them all. I quit obsidian

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

When trying to debug this, remove the auto-merging pull-request. It will help to prevent restoring in loop the deleted file, while allowing checking the push.

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

BTW the file won't be deleted in your vault! Only in your repository. If they don't have the share:key and not in your repo, nothing will happend.
Do you have the log message about deleting file ?

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

Okay, I think i found the error, could you try to download the beta ? You can do it using BRAT or manually!

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

I had to leave the office ... will check tomorrow! thanks!

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

Hello! Any update ?

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

I am so sorry. I am running from one meeting to the next … hope I have an hour at the office tomorrow

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

Take your time! Good luck at your job :)

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

Hello!
I'm sorry, I wait for your message/reply before pushing the beta to prod!

from obsidian-github-publisher.

ArneNostitz avatar ArneNostitz commented on July 22, 2024

hi, so sorry ... i am on a shoot with 16h days ... i will be back on my obsidian hopefully soon - but could be that i am shooting until march ...

can you post a link to the beta here so i can download? dont know what "brat" is. 😬 will try to do it on the weekends somehow. cant guarantee thou - really sorry bout that

from obsidian-github-publisher.

QuickFastly avatar QuickFastly commented on July 22, 2024

This may not be the same bug since I didn't get an error saying the repo was empty, but when I tried to update my repo today, every single note got deleted with no warning and no apparent errors. Disabling auto clean didn't help, uploading single files didn't work. I was initially using version 5.3.1, then tried again after updating to 5.3.2 with the same problem, no new notes were uploaded. Every pull request only contained my attachments, never any .md files, even though the plugin appeared to be working normally, even with notice every error enabled.

I tried downgrading to a few different older versions, same problem every time, until ultimately I landed on 4.12.0 where it finally started working again. But on that version, while uploading the whole vault works, uploading a single note causes every other note to be deleted when auto clean is enabled. Downgraded again to 4.11.0 and the same behavior happens. I don't have any more information, unfortunately.

Sorry for being unhelpful, but at this point I just want my workflow to work so I'm going to stick with the old version and just deal with the fact that I have to upload the whole vault for every update if I want auto clean, but wanted to at least confirm that there is in fact something going wrong somewhere.

from obsidian-github-publisher.

Lisandra-dev avatar Lisandra-dev commented on July 22, 2024

Please, reopen a issue with your configuration, command used, log to get more help.

Please keep in mind that I code GitHub Publisher entirely alone, for free.

from obsidian-github-publisher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.