[Bug]: <img>'s src aren't getting a base path correctly (attachmentLinks) about obsidian-github-publisher HOT 8 CLOSED

Found the culprit: apparently targetList.filter((x) => !sourceList.includes(x)) is removing the word obsidian from images/obsidian/naming.png. I don't understand why it needs to drop a directory, unsure whether it's a feature for something else or a bug.

Here's the screenshot with all values. Notice at the end, it drops the directory:

Can you advise on how to fix this? I'm afraid it'd break other things that are expected somewhere else 😬 This is the last remaining block to get my blog to get published from Obsidian 😄

from obsidian-github-publisher.

I Will check that ! Don't worry :D

from obsidian-github-publisher.

I pushed a beta version of this fix, could you please try it and keep me informed about it ?

from obsidian-github-publisher.

I can confirm it worked with 4.3.7-0 (beta) 😄

from obsidian-github-publisher.

I noticed now that links aren't working, and I think it might be due to this change (need to confirm).

Here's my config:

Here is the screenshot in Obsidian showing from about (source) to my-digital-workbench (target).

Note that:

• the my-digital-workbench file has frontmatter filename: _pages/my-digital-workbench (with _pages),
• the file is deployed to obsidian/_pages/my-digital-workbench as expected,
• but the final link in about points to obsidian/my-digital-workbench, omitting _pages.

from obsidian-github-publisher.

As I can see, It's not a markdown or wikilinks no ? My regex for internal links only work on these

from obsidian-github-publisher.

Hm... yes it is. If you check again this image, the wikilink [[my-digital-workbench|Check out my work setup]] on the bottom right pane is a link.

from obsidian-github-publisher.

This seems to be the same issue I'm currently struggling with. The image links in my posts start with "/posts/" but the images are at the same link but without that. I was actually following your blog post, @kurko, though what I assume was the solution you figured out (the text replacer) has not been working for me. Any ideas?

from obsidian-github-publisher.