Giter Club home page Giter Club logo

Comments (6)

lalitpagaria avatar lalitpagaria commented on May 20, 2024 1

There are plans to add automated model retraining/finetuning but they will be outside of Obsei. Idea to keep isolation between model serving part and training/finetuning part. First we might need to think how to collect feedback about model prediction automatically from the user.

For now we can go ahea with pythonic implementation.

from obsei.

shahrukhx01 avatar shahrukhx01 commented on May 20, 2024

@lalitpagaria I think here we can use PyTorch data loaders, it'd elegantly batch data for us.

from obsei.

lalitpagaria avatar lalitpagaria commented on May 20, 2024

@shahrukhx01 If I am correct, you are talking about this https://pytorch.org/docs/stable/data.html ?
But it will add dependency to pytorch for other parts like source, sink and few simple non transformers based analyzer.
How about using simple solution like following -
https://stackoverflow.com/questions/8290397/how-to-split-an-iterable-in-constant-size-chunks

Also currently in analyzers we are calling transformers pipeline for single text sequentially. But few pipeline support list[str] so we can leverage transformers internal batching as well.

from obsei.

shahrukhx01 avatar shahrukhx01 commented on May 20, 2024

@lalitpagaria yes, if that's the case then we can go with the plain pythonic implementation, as long as you don't have any plans to add automated model retraining/finetuning, then such implementation can come handy, otherwise, what you suggested fits our requirement.

from obsei.

shahrukhx01 avatar shahrukhx01 commented on May 20, 2024

@lalitpagaria Could you please confirm which of the following analyzers need this change? Since, this won't take much I'll create a quick PR on this based on the pythonic approach

  1. base_analyzer.py
  2. classification_analyzer.py
  3. dummy_analyzer.py
  4. ner_analyzer.py
  5. pii_analyzer.py
  6. sentiment_analyzer.py
  7. translation_analyzer.py

from obsei.

lalitpagaria avatar lalitpagaria commented on May 20, 2024

Almost all as each receive list as input. Just to make sure batch_size input param should be configurable.

from obsei.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.