Comments (6)
obi1kenobi
commented on August 29, 2024
New nightly has a new rustdoc format. It's already supported on HEAD, I
just need to find some time to cut a new release.
…On Mon, Dec 25, 2023, 7:33 AM Joshua Liebow-Feeser ***@***.***> wrote:
Zerocopy's CI jobs started failing yesterday, e.g. here
<https://github.com/google/zerocopy/actions/runs/7315752855/job/19929732539?pr=750>.
In total, we've seen this issue on PRs google/zerocopy#749
<google/zerocopy#749> and google/zerocopy#750
<google/zerocopy#750>. The relevant error seems
to be:
/home/runner/.cargo/bin/cargo semver-checks check-release --package zerocopy --all-features
Parsing zerocopy v0.8.0-alpha.1 (current)
Error: rustdoc format v28 for file /home/runner/work/zerocopy/zerocopy/semver-checks/target/semver-checks/target/doc/zerocopy.json is not supported
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
The PR most recently merged into main is google/zerocopy#748
<google/zerocopy#748>, and its CI tests passed,
so I don't believe this is caused by a change in zerocopy's codebase.
—
Reply to this email directly, view it on GitHub
<#61>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5MSR4XNBAZUR2EYEAHMLYLFXC7AVCNFSM6AAAAABBCKOMCGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKNRWGA2TCMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from cargo-semver-checks-action.
obi1kenobi
commented on August 29, 2024
cargo-semver-checks `main` branch HEAD, not this repo
On Mon, Dec 25, 2023, 8:29 AM Predrag Gruevski ***@***.***>
wrote:
… New nightly has a new rustdoc format. It's already supported on HEAD, I
just need to find some time to cut a new release.
On Mon, Dec 25, 2023, 7:33 AM Joshua Liebow-Feeser <
***@***.***> wrote:
> Zerocopy's CI jobs started failing yesterday, e.g. here
> <https://github.com/google/zerocopy/actions/runs/7315752855/job/19929732539?pr=750>.
> In total, we've seen this issue on PRs google/zerocopy#749
> <google/zerocopy#749> and google/zerocopy#750
> <google/zerocopy#750>. The relevant error seems
> to be:
>
> /home/runner/.cargo/bin/cargo semver-checks check-release --package zerocopy --all-features
> Parsing zerocopy v0.8.0-alpha.1 (current)
> Error: rustdoc format v28 for file /home/runner/work/zerocopy/zerocopy/semver-checks/target/semver-checks/target/doc/zerocopy.json is not supported
> Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
>
> The PR most recently merged into main is google/zerocopy#748
> <google/zerocopy#748>, and its CI tests passed,
> so I don't believe this is caused by a change in zerocopy's codebase.
>
> —
> Reply to this email directly, view it on GitHub
> <#61>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAR5MSR4XNBAZUR2EYEAHMLYLFXC7AVCNFSM6AAAAABBCKOMCGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKNRWGA2TCMQ>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
from cargo-semver-checks-action.
joshlf
commented on August 29, 2024
Sounds good, thanks! Whenever that happens, could you comment here so I know that these PRs are unblocked? No rush on our side - we're not getting a lot done right now because of the holidays.
from cargo-semver-checks-action.
joshlf
commented on August 29, 2024
Update: we were able to work around this by using our pinned nightly toolchain for cargo-semver-checks in google/zerocopy#753.
from cargo-semver-checks-action.
obi1kenobi
commented on August 29, 2024
google/zerocopy#753 is a good idea.
If you or others would like an SLA for supporting new nightly releases, or extended support for specific Rust versions or rustdoc formats, I'm happy to offer that under a commercial support contract. Please reach out to me over email, which you can find in the cargo-semver-checks project's Cargo.toml.
Otherwise, I aim to support the most recent few stable releases. The exact number of releases left unspecified since it's a function of rustdoc format changes and/or discovered bugs in rustdoc that affect semver-checking. I don't promise any timeline or SLA whatsoever on supporting new nightly releases.
I may also drop support for rustdoc formats that never made it into any stable Rust even though older stable formats may still be supported. For example, cargo-semver-checks v0.24 supported rustdoc formats v24, v26, and v27, and did not support rustdoc v25 because that format was never used in a stable Rust release and was only part of a few nightly Rust versions before being superseded by v26. It's possible that your pinned nightly as in google/zerocopy#753 may occasionally fall on such an "unlucky" format — in such situations, I'd recommend either:
- choosing a different nightly to pin to, or
- setting up a support and reciprocal access contract with me so I know to continue supporting those versions.
In the case of Google, I know that the company has signed support and reciprocal access contracts with other open-source maintainers so that'd be something I'd be interested in as well, if you're open to looking into it internally!
from cargo-semver-checks-action.
obi1kenobi
commented on August 29, 2024
The new release is building now and should be available shortly. It will get used automatically once the build completes.
https://github.com/obi1kenobi/cargo-semver-checks/actions/runs/7349612629
from cargo-semver-checks-action.
Related Issues (20)
- Allow enabling verbose output HOT 1
- Action can get stuck if rustdoc changes behavior from one Rust version to another HOT 2
- Add `manifest-path` option to specify the path to the Cargo.toml to check HOT 5
- Generates warning about set-output command being deprecated HOT 3
- Different behavior between the Github action and the CLI HOT 3
- Full support for ARM-based systems
- example code is broken HOT 6
- Action v2 should version the cache based on cargo-semver-checks and Rust toolchain versions HOT 1
- Action v2 should adopt Rust toolchain setup best practices from dtolnay/rust-toolchain
- Can't run against `publish = false` crates, but there's a workaround HOT 1
- Include `package` and `manifest-path` in the cache key HOT 1
- Node `Buffer`-related deprecation warning
- Allow specifying the version of `cargo semver-checks` HOT 11
- Fails if workspace contains a crate that is not yet published
- Support testing for different targets? HOT 12
- Include target name in the cache key HOT 6
- Typo in README: "feature" option should be "features" HOT 1
- Should update to node20 due to node16 deprecation HOT 1
- Add action outputs HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-semver-checks-action.