Giter Club home page Giter Club logo

Comments (10)

srio avatar srio commented on July 28, 2024

The results are similar for Graphite and Si, I mean you see that shadow autosetting sets the crystal to the "corrected Bragg angle" but using external profile, the crystal is set to the "uncorrected" Bragg angle. The latter is done by the interface, and cannot be done better.
image

For getting the angles that are really used in the calculation, you should see the o.e. "info", and here you see that for Graphite they are indeed (slightly!) different:
image

The numerical value you see in the interface is autofilled by the interface and corresponds to the Bragg angle and not to the corrected Bragg angle. It is only an indication (I accept that it could be confusing...).

Does this answers the question?

regards, Manuel

from shadow3.

91902078 avatar 91902078 commented on July 28, 2024

I use corrected bragg angle by choosing th-th bragg (corrected) in crystal widget for 2nd graphite config, I expect both curves almost overlapped in the center position, but not expect to get different
graphite corrected

from shadow3.

91902078 avatar 91902078 commented on July 28, 2024

I use my version Shadow, in above setting, get overlapped in central position
graphite corrected-my

my version has minor change in CRYSTAL subroutine in shadow_kernel.f90
CRYSTAL_func

from shadow3.

91902078 avatar 91902078 commented on July 28, 2024

For Si 111, if use same corrected bragg angle in CRYSTAL widget in 2nd configure, also get overlapped in central position
Si111 corrected

from shadow3.

srio avatar srio commented on July 28, 2024

I am not sure if I understood correctly the problem.

If I use autosetting in shadow, the histogram should be centered at zero (because it calculates the Bragg corrected angle)
This happens with Graphite for the 3 ways to calculate the preprocessor file (v1, v2-dabax, v2-xraylib):
image

I get the same centered histogram if I do not use auto-setting and copy/paste the angles:
Incidence Ang. 81.123721 deg
Reflection Ang. 81.123721 deg

Up to here, it looks OK for me.

If you use external profile from xoppy/crystal, the shadow uses the angle defined in the "position" tab. This is changed when you have the xoppy/crystal widget connected and you "run" it. It is set at the uncorrected Bragg angle, so typically you see the resulting histogram not centered. But this is external to shadow3.

Another interesting point is your change in fortran. It looks at a first view that indeed you corrected a bug. But this is only affecting the v1 preprocessor. It is strange that I see no major differences in my comparison (see fig) from v1 (buggy?) to v2 (correct?). This I do not understand and would need a more careful look...

from shadow3.

91902078 avatar 91902078 commented on July 28, 2024

from shadow3.

srio avatar srio commented on July 28, 2024

Yes, it is a bug. I will fix and upgrade shadow3 soon (in 1 or 2 days).
Thanks a lot for reporting the problem and giving the solution...

from shadow3.

srio avatar srio commented on July 28, 2024

Fixed in shadow3 22.8.25 shadowOui 1.5.202

from shadow3.

91902078 avatar 91902078 commented on July 28, 2024

Thanks!

from shadow3.

91902078 avatar 91902078 commented on July 28, 2024

Test successfully!

from shadow3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.