Giter Club home page Giter Club logo

Comments (4)

khalwat avatar khalwat commented on August 24, 2024 1

Addressed in: 8a2e4ed & 69b4a3e

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop as 3.2.9",

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop-v4 as 4.1.11",

Then do a composer clear-cache && composer update

from craft-retour.

khalwat avatar khalwat commented on August 24, 2024

Addressed in: 72af1f3 & 0f62cc8

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop as 3.2.9",

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop-v4 as 4.1.11",

Then do a composer clear-cache && composer update

from craft-retour.

JasonStainton avatar JasonStainton commented on August 24, 2024

Thanks for this, it was the other route I was thinking of but the code seemed like it was perfect not to be used 😄

@khalwat - I can see the before and after events but can't see the resolved event (which is the one I'm actually trying to target).

Thinking that one will need to sit in the findRedirectMatch() method to match how it's used in resolveRedirect()? Also, should that event trigger when a cached redirect is returned too? It has resolved to get a redirect after all.

I'll avoid the PR embarrassment this time 😅

from craft-retour.

khalwat avatar khalwat commented on August 24, 2024

Ah my bad, I'll get that in there.

And no, those events shouldn't fire if they are cached.

from craft-retour.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.