Attaching two images with no caption misses an image about rapidpro HOT 5 CLOSED

Without activity, this issue will be closed in 14 days.

from rapidpro.

This issue was closed for inactivity.

from rapidpro.

We should look into this, assigning it so it stays active.

from rapidpro.

I looked into this and I found

Telegram sends 2 different requests for each attachments however there is a new field in that case we could probably use media_group_id that is the only value that is the same.

And when no caption is added the second attachment is ignore as the msg is considered a dupe by https://github.com/nyaruka/courier/blob/f76152aee193dac87b9d0c5a54fc048777d1e191/backends/rapidpro/msg.go#L431

We can probably hash the attachment in the fingerprint too so that message with empty text but different attachments are always accepted.

The solution is in 2 steps:

1. first make sure we never ignore any messages with different attachments with empty text
2. find a way to merge multiple requests into the existing message when both have the same media_group_id, so appending the attachments to the previous saved message

from rapidpro.

1. is addressed by nyaruka/courier#607

With that we will no longer miss the second attachment

from rapidpro.