Giter Club home page Giter Club logo

Comments (4)

rowanseymour avatar rowanseymour commented on September 18, 2024 1

We're not trying to get smart about broadcasts sent to one contact - sending a broadcast should always create a broadcast. Flow editor never calls these endpoints because it never directly sends anything.

Just need to update chat widget on new UI contact read page and on ticket read page (same in old and new UI).

from rapidpro.

susanm74 avatar susanm74 commented on September 18, 2024

@rowanseymour ok i think this one is mostly clear (re: chatbox on the contact read and ticket pages), but do we expect this update to be needed across both the floweditor and temba-components repos? i think there are some scenarios where something in a flow could result in a "single messsage send" ex. if a flow contains the send msg node and only specifies one contact? also, i think in the old ui there is a "send message" button which brings up a modal specifying just the one contact?... so yeah, just want to confirm what's included in the scope of this work...

and then below are just a few quick questions to sanity check any discrepancies with the work across repos, old vs. new ui, and to also snag any relevant navigation steps/links to more quickly zero in on where the change needs to happen:

  • repo - changes needed in only floweditor vs only temba-components vs both?
  • ui - changes needed for only new ui vs. partial old and new ui vs both old and new ui?
    • only new ui => no affect to old ui
    • partial old and new ui => needs to maintain status quo display/behavior of old ui
    • both old and new ui => will result in a change of display/behavior in old ui
  • navigation - link/steps to where change is needed in old and new ui?

thanks for bearing with on the above!

from rapidpro.

ericnewcomer avatar ericnewcomer commented on September 18, 2024

One issue with this is that we probably want a created_by on Msg before making this change. This is pretty important in the ticketing view to see which agent sent which message. Today, this uses Broadcast.created_by

from rapidpro.

rowanseymour avatar rowanseymour commented on September 18, 2024

@ericnewcomer good point - just made #4379 and nyaruka/mailroom#44

from rapidpro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.