setVibrancy() broken on macOS about glasstron HOT 6 CLOSED

ok but is this on master branch?
Also, from Electron's docs:

Please note that using frame: false in combination with a vibrancy value requires that you use a non-default titleBarStyle as well

from glasstron.

Yep - master. Looks like an array gets passed to setVibrancy here: 424075d#diff-748ec3715bf7cb233256e7732e80a644d9e75e74a5080942e33ff3cd7e5afe8cR81 and also _vibrancy[1] is always null if you only use setVibrancy without setBlur

from glasstron.

Yep - master. Looks like an array gets passed to setVibrancy here: 424075d#diff-748ec3715bf7cb233256e7732e80a644d9e75e74a5080942e33ff3cd7e5afe8cR81 and also _vibrancy[1] is always null if you only use setVibrancy without setBlur

I was trying to wrap Electron's setVibrancy so that I can also provide a global switch with setBlur and a way to get the vibrancy value back. Not really needed as you know but I want them there. I still lack a Mac to test my approach and maybe there's a bug I never dug up just by looking at the code.

In Glasstron's realm, you toggle the blur via setBlur() and vibrancy is just a property like blurType is on Windows

from glasstron.

Does it work as intended in 0.0.6?

from glasstron.

No. In platforms/darwin.js, _vibrancy[1] is used to actually set vibrancy, but it's always null. You probably should check vibrancy[0] here: https://github.com/AryToNeX/Glasstron/blob/master/src/platforms/darwin.js#L75

from glasstron.

Can you test it and make a pull request? I am with you on that one thing, but I got really no time to make the change myself lately.

from glasstron.