Giter Club home page Giter Club logo

Comments (14)

nwesterhausen avatar nwesterhausen commented on June 15, 2024 1

Death messages are added in 0.8.0, at least in my testing of my client to my server.

from valheim-discordconnector.

nwesterhausen avatar nwesterhausen commented on June 15, 2024

Did you roll back to 0.7.0 or 0.6.0?

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

Did you roll back to 0.7.0 or 0.6.0?

0.7.0
I guess technically not a rollback lol, as I went 0.6.0 --> 0.7.1 --> 0.7.0

I'd try to repeat it, except its an active server... I could probably start up a dedicated world for testing though, probably a good idea...

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

Did you roll back to 0.7.0 or 0.6.0?

I rolled back to 0.6.0 now... & a player is on who dies a lot, so I should be able to tell you soon if it only started with 0.7.0

EDIT: The starting up message was fixed in 0.7.0 as I rolled back to 0.6.0 and it's now missing again

EDIT2: the double join message after a death existed in 0.6.0 as well, so I will go back to 0.7.0 and disable join messages for now =\

from valheim-discordconnector.

nwesterhausen avatar nwesterhausen commented on June 15, 2024

I just was able to test 0.7.0 and had it block a user that wasn't in the list from the shouts (and therefore pings) and then when I respawned from dying said I joined twice.

Going to get to the bottom of it

from valheim-discordconnector.

nwesterhausen avatar nwesterhausen commented on June 15, 2024

So I used the wrong comparison... was guaranteed to find non-matches and stop instead of matching and stopping

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

Nice =]
It's mostly working using two plugins, but I am very much looking forward to trying the new version this evening when I am tinkering around the server. I'll let you know if I notice anything out of the ordinary.

from valheim-discordconnector.

nwesterhausen avatar nwesterhausen commented on June 15, 2024

I think the only thing not fixed at the moment is two join messages when one should be a death message -- but I have to figure out a way to tell. Might have to record the player joining the first time then if they did, send a death message. I don't think they can disconnect without the server noticing. Going to try that now actually

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

I think the only thing not fixed at the moment is two join messages when one should be a death message -- but I have to figure out a way to tell. Might have to record the player joining the first time then if they did, send a death message. I don't think they can disconnect without the server noticing. Going to try that now actually

If you ever need a 2nd person to jump in for some sort of testing, I'm available often for the time being and during random hours.

z.#8068

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

Death messages are added in 0.8.0, at least in my testing of my client to my server.

I was wondering what in the world lol... went to download 0.7.1 from Nexus instead of here to Endorse it, and then saw 0.7.2 and 0.8.0

That sounds awesome because that is the only thing Notifier still had so I should be able to remove the it if this works =]
Doing that now...

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

It is now only a single join message instead of two...

is the join message intentional? As the player didnt actually leave the world... or it is something that has to be circumvented because it goes back to the loading screen in-between death/respawn

EDIT: I re-added notifier to just take over death events while that join message is still appearing, but then discovered that
Player Death Notifications = false doesn't work; death messages still notify even when it's false

EDIT2: I thought I'd actually go the other way and that other handle joins and let yours do deaths (as the multiple death messages are really fun to have), but found another bug in the process
If join notifications are false, then death messages wont show either.

from valheim-discordconnector.

nwesterhausen avatar nwesterhausen commented on June 15, 2024

This is fixed in 0.9.0 -- turns out I had removed the check for join and death messages being enabled

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

I will check & test death messages specifically before noon (2-3pm)

from valheim-discordconnector.

CruxCraft avatar CruxCraft commented on June 15, 2024

Appears fixed on the test server =] Thanks

from valheim-discordconnector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.