Question: is intended behavior to return custom icon only on exact match? about nvim-web-devicons HOT 7 CLOSED

This was intended behavior. I wrote this plugin to solve performance issues in my tree regarding vim-devicons, but my tree only needs to pass the filename as it is so it does not really matter to me.
Thing is, the more we add more logic inside this plugin, the slower it'll get for every user of the library. A note in the readme might be more appropriate, although i'm not sure the performance implications would be tremendous adding some parsing logic on the pathnames. I think i would accept a PR :)

from nvim-web-devicons.

@saviocmc Do you know if your solution was adopted by Telescope team?

from nvim-web-devicons.

@gegoune Yes, it was! Telescope now uses only the file name (not the complete file path, as before) to call this plugins, this way the icons are always consistent. This issue can be closed. Sorry for the delay, appreciate your work.

from nvim-web-devicons.

For future reference, here is the helper function that seems to do the trick:

https://github.com/nvim-telescope/telescope.nvim/blob/a3f17d3baf70df58b9d3544ea30abe52a7a832c2/lua/telescope/utils.lua#L175

Perhaps it could be added to this plugin as an input sanitization step if it proves not to be a significant performance hit.

from nvim-web-devicons.

That's is a good news, thank you for getting back to us!

from nvim-web-devicons.

@alex-courtis Wouldn't #84 (comment) solve regex issues?

from nvim-web-devicons.

@alex-courtis Wouldn't #84 (comment) solve regex issues?

We could add an option like the very recently added strict https://github.com/nvim-tree/nvim-web-devicons#get-icon

I'm very hesitant to make any changes that might break existing behaviour, as the blast radius for this plugin is very large.

from nvim-web-devicons.