Giter Club home page Giter Club logo

Comments (5)

kyazdani42 avatar kyazdani42 commented on July 20, 2024 3

Hi, yes i agree with akinsho, although it's a 'fork', i would like to preserve a library like functionality for this plugin. Implementing code for other plugins would be too much work and i do not aim for that. Also i've written my own tree plugin and that's when i had to rewrite vim-devicons because it was too slow and did not match my requirement in term of usability. People are free to fork and extend this to support plugins like nerdtree or airline though :)

from nvim-web-devicons.

akinsho avatar akinsho commented on July 20, 2024

I think this question is reversed. I'm not sure what support would look like/means in this case? If it means can these icons be used in those plugins then I think the onus to add this would be on airline or other plugins to somehow adds this functionality themselves and make this plugin a dependency not really the other way around.

For the most part other consumers of the plugin like telescope.nvim, barbar.nvim, nvim-bufferline.lua, galaxyline.lua have implemented integrations themselves without anything needing to be done on this plugin's side. Both plugins you mention are written in vimscript and would need to special case using this plugin to nvim with access to lua 🤷🏿‍♂️ which is possible but definitely something (IMO) for them to do if they wanted.

from nvim-web-devicons.

entropitor avatar entropitor commented on July 20, 2024

Oh okay, I'm asking because when I also install https://github.com/ryanoasis/vim-devicons, airline and nerdtree get icon support out of the box, I assumed it was done by https://github.com/ryanoasis/vim-devicons and not by nerdtree, airline, ... but I could be mistaken

Given it was "a fork of" that project, I was expecting it to work out of the box as well. I get that it's not easy because of vim<>lua

from nvim-web-devicons.

akinsho avatar akinsho commented on July 20, 2024

@entropitor I actually just dug through the devicons code base searching for nerdtree and airline and you're right vim-devicons specifically hooks into apis exposed by those plugins and integrates with them. Tbh only @kyazdani42 can give you a definitive answer but imo both those integrations each look to be quite a lot of vimscript, and really seem like they should have been done in the specific plugins not by vim-devicons since it seems to go beyond the remit of what is essentially an icon pack 🤷🏿‍♂️ . Looks like it would be very awkward at best to try and make either of those plugins work with this package.

from nvim-web-devicons.

entropitor avatar entropitor commented on July 20, 2024

Okay, that's a fair point. I was just wondering 👍

from nvim-web-devicons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.