Add ability to choose ubuntu version for llvm upstream repository about hpc-container-maker HOT 9 CLOSED

Tracing through the linked recipe script, I think I understand the issue. Here's a short reproducer:

compiler = llvm(upstream=True)
image = baseimage(image='ubuntu:20.04')

Stage0 += image
Stage0 += compiler

Running this recipe through hpccm --recipe ... pulls in the xenial repo. Note that the llvm building block is referenced before the baseimage primitive.

The logic to set the Linux distribution type and version is in baseimage. Since llvm is called prior, it's using the default Ubuntu 16.

In the reproducer, if you exchange the first two lines, you get the expected focal repo.

I recommend moving the call to the baseimage primitive (stages['main'] += hpccm.primitives.baseimage(image=base_image_tag(args)) to the top of the build_stages function so that the correct Linux distribution is set before calling any of the building blocks.

from hpc-container-maker.

Thanks for the tip, I'll see that we rework our script then!

from hpc-container-maker.

I did rework the GROMACS script, but Sam's advice broke a cross-stage dependency we have. I found nothing more attractive to do than making a dummy stage that adds hpccm.primitives.baseimage(image=base_image_tag(args)) before any of the others. See https://gitlab.com/gromacs/gromacs/-/merge_requests/1764/diffs#14c7f142b515dba43cbfed3d95fe0b785b000384_636_636

from hpc-container-maker.

There still seems to be an issue, even when using the correct order of includes. The script adds https://apt.llvm.org/focal llvm-toolchain-focal-8 Release to the package includes, but this repository doesn't exist.

from hpc-container-maker.

If I'm following GROMACS script properly, I think the distro LLVM and upstream LLVM cases need to be separated. You're setting llvm(upstream=True, version='8') which isn't valid for the upstream. Or you could do something like llvm(upstream=False if v == '8' else True, version=v).

An alternative to the dummy stage approach is to use the hpccm.config.set_linux_distro().

from hpc-container-maker.

Thanks, those were very helpful suggestions. We're trying them out at https://gitlab.com/gromacs/gromacs/-/merge_requests/1764/diffs#14c7f142b515dba43cbfed3d95fe0b785b000384

from hpc-container-maker.

I think logic like upstream=True if int(args.llvm) > 11 else False is needed to have the comparison working correctly as an int, not a string.

from hpc-container-maker.

Closing. Please reopen if the issue persists.

from hpc-container-maker.

We resolved our issue, thanks!

from hpc-container-maker.